From e6bb5ecb0160ddce88d78efb22d37631e0fd7862 Mon Sep 17 00:00:00 2001 From: David Stone Date: Sun, 28 Jun 2026 11:38:02 -0700 Subject: [PATCH] chore(cdk): set cross-stack reference strength and drop unused binding MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Set the @aws-cdk/core:defaultCrossStackReferences feature flag explicitly to "strong" to silence CDK's "No cross-stack-reference strength configured" warning. The project's only cross-stack reference is the ACM cert passed from TrashcalCertStack (us-east-1) to TrashcalCdkStack (us-west-2), which is a cross-region reference implemented via SSM parameters rather than CloudFormation exports, so this flag has no behavioral effect here — it just locks in current behavior. Also remove the unused `uploadRole` binding introduced in the CloudFront access-logs change. The GithubActionsRole construct registers itself with the stack on construction, so the role is still synthesized; only the dangling variable is gone. Co-Authored-By: Claude Opus 4.8 (1M context) --- cdk/cdk.json | 3 ++- cdk/lib/trashcal-cdk-stack.ts | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/cdk/cdk.json b/cdk/cdk.json index 23f2a150..a685fa93 100644 --- a/cdk/cdk.json +++ b/cdk/cdk.json @@ -67,6 +67,7 @@ "@aws-cdk/aws-eks:nodegroupNameAttribute": true, "@aws-cdk/aws-ec2:ebsDefaultGp3Volume": true, "@aws-cdk/aws-ecs:removeDefaultDeploymentAlarm": true, - "@aws-cdk/custom-resources:logApiResponseDataPropertyTrueDefault": false + "@aws-cdk/custom-resources:logApiResponseDataPropertyTrueDefault": false, + "@aws-cdk/core:defaultCrossStackReferences": "strong" } } \ No newline at end of file diff --git a/cdk/lib/trashcal-cdk-stack.ts b/cdk/lib/trashcal-cdk-stack.ts index bfaf875c..b021db65 100644 --- a/cdk/lib/trashcal-cdk-stack.ts +++ b/cdk/lib/trashcal-cdk-stack.ts @@ -36,7 +36,7 @@ export class TrashcalCdkStack extends cdk.Stack { this, "GithubProvider", ); - const uploadRole = new GithubActionsRole(this, "UploadRole", { + new GithubActionsRole(this, "UploadRole", { provider: provider, owner: "stabbylambda", repo: "trashcal",