Skip to content

[hygiene] Port naming, progressDeadline, annotations prefix, yamllint #40

Description

@henzigo

Context

Cosmetic/consistency debt inherited 1:1 from the legacy manifests:

  • port naming: adopt the protocol-prefix convention across deployments AND services —
    http, http-health (webserver), http (storefront), redis + http-metrics (redis),
    amqp + http-management + http-metrics (rabbitmq, coordinated with [infra] RabbitMQ hardening: ports, probes, graceful restart #6)
  • progressDeadlineSeconds: 1500 (25 min) on webserver + cron — reduce to 600 s or
    document why longer is needed; blocks CI for 25 min on a stuck rollout
  • hostAliases on the webserver pod (127.0.0.1 self-reference) — add the explanatory
    comment (self-calls must not round-trip through the Service) or remove if the app no longer
    needs it (verify!)
  • project/* annotationsshopsys.com/* DNS-style prefix
  • protocol: TCP consistency (either everywhere or nowhere)
  • yamllint for the repo (templates + values + environments) in CI

Tasks

  • Port renames (deployments + services, numeric targets unchanged = zero-impact)
  • progressDeadlineSeconds decision + change
  • hostAliases comment/verification
  • Annotation prefix migration (documented in deviations — log collectors may filter on it!)
  • yamllint config + CI job
  • Golden snapshots

Related: #6

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/app-chartshopsys-app chart (workloads, ingresses, secrets, hooks)area/infra-chartshopsys-infra chart (Redis, RabbitMQ, RBAC)behavior-changechanges rendered manifests - regenerate golden snapshots + update deviations docenhancementNew feature or requestgood first issueGood for newcomerspriority/low

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions