FCP poll for ErrorKind::OutOfMemory

[joshtriplett]

I unintentionally merged #84744 without first starting an FCP. We'd previously discussed adding more ErrorKind values, but nonetheless this specific change should have gone through FCP. I've opened this issue to check consensus on this change; if there's any issue with it, I'll post a revert.

[joshtriplett]

@rfcbot merge

[rfcbot]

Team member @joshtriplett has proposed to merge this. The next step is review by the rest of the tagged team members:

• @Amanieu
• @BurntSushi
• @dtolnay
• @joshtriplett
• @m-ou-se
• @sfackler
• @yaahc

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

[BurntSushi]

One question I had is, other than #84744, where might we use this?

[joshtriplett]

@BurntSushi Anywhere that calls last_os_error() when errno is ENOMEM (or the equivalent on Windows). While on Linux it's common to invoke the OOM killer rather than return ENOMEM, it's possible to disable that (and some systems do), and other systems do return ENOMEM. And even on Linux with overcommit and OOM, there are ways to get ENOMEM; for instance, you could get this from fork() of a process using a substantial amount of the system's memory, so it could bubble up from Command.

[BurntSushi]

@joshtriplett Understood. Thanks for explaining that! This SGTM then.

[rfcbot]

🔔 This is now entering its final comment period, as per the review above. 🔔

[rfcbot]

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.