Unescapes test failure

[wenderjean]

Hi guys,

I'm in the process of setting up Prism on a fresh Debian installation, following instructions provided in README. It went smoothly until I attempted to run the suite of tests. For some reason, test/prism/unescape_test.rb is triggering 6 assertion failures to me. Once the main branch is green, I suspect it may be something related to the environment.

$ uname -a
Linux Workstation 6.1.0-16-arm64 #1 SMP Debian 6.1.67-1 (2023-12-12) aarch64 GNU/Linux

$ gcc --version
gcc (Debian 12.2.0-14) 12.2.0
Copyright (C) 2022 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

$ ruby --version
ruby 3.3.0preview1 (2023-05-12 master a1b01e7701) [aarch64-linux]

$ bundle --version
Bundler version 2.3.6

$ bundle exec rake compile
make
make: Nothing to be done for 'all'.
/usr/bin/gmake install sitearchdir=../../../../lib/prism sitelibdir=../../../../lib/prism target_prefix=
/usr/bin/install -c -m 0755 prism.so ../../../../lib/prism
cp tmp/aarch64-linux/prism/3.3.0/prism.so tmp/aarch64-linux/stage/lib/prism/prism.so

$ bundle exec rake
☑  manifest looks good
make
make: Nothing to be done for 'all'.
/usr/bin/gmake install sitearchdir=../../../../lib/prism sitelibdir=../../../../lib/prism target_prefix=
/usr/bin/install -c -m 0755 prism.so ../../../../lib/prism
cp tmp/aarch64-linux/prism/3.3.0/prism.so tmp/aarch64-linux/stage/lib/prism/prism.so
Loaded suite /home/wender/.rvm/rubies/ruby-3.3.0-preview1/lib/ruby/gems/3.3.0+0/gems/rake-13.0.6/lib/rake/rake_test_loader
Started
F
Failure: test_reg1(Prism::UnescapeTest)
/home/dev/prism/test/prism/unescape_test.rb:231:in `assert_unescape'
/home/dev/prism/test/prism/unescape_test.rb:192:in `assert_context'
/home/dev/prism/test/prism/unescape_test.rb:141:in `test_reg1'
     138:     def test_lwrs; assert_context(Context::Symbol.new("%s[", "]")); end
     139:     def test_sym1; assert_context(Context::Symbol.new(":'", "'")); end
     140:     def test_sym2; assert_context(Context::Symbol.new(":\"", "\"")); end
  => 141:     def test_reg1; assert_context(Context::RegExp.new("/", "/")); end
     142:     def test_reg2; assert_context(Context::RegExp.new("%r[", "]")); end
     143:     def test_reg3; assert_context(Context::RegExp.new("%r<", ">")); end
     144:     def test_reg4; assert_context(Context::RegExp.new("%r{", "}")); end
Expected // to unescape "u{005ecb \t\v 005eAF}" to "\\u{005ecb 005eAF}", but got "\\u{005ecb \t\v 005eAF}"
<[92, 117, 123, 48, 48, 53, 101, 99, 98, 32, 48, 48, 53, 101, 65, 70, 125]> expected but was
<[92,
 117,
 123,
 48,
 48,
 53,
 101,
 99,
 98,
 32,
 9,
 11,
 32,
 48,
 48,
 53,
 101,
 65,
 70,
 125]>

diff:
+ [92,
? [92, 117, 123, 48, 48, 53, 101, 99, 98, 32, 48, 48, 53, 101, 65, 70, 125]
+  123,
+  48,
+  48,
+  53,
+  101,
+  99,
+  98,
+  32,
+  9,
+  11,
+  32,
+  48,
+  48,
+  53,
+  101,
+  65,
+  70,
+  125]

...

Finished in 2.506006734 seconds.
----------------------------------------------------------------------------------------------------------------------------------
2443 tests, 498728 assertions, 6 failures, 0 errors, 0 pendings, 0 omissions, 0 notifications
99.7544% passed
----------------------------------------------------------------------------------------------------------------------------------

I've tried the approach guys described here running the suite a couple of times but no success at all.

[eregon]

ruby 3.3.0preview1 is old and as a preview might be rather buggy/unstable, could you try with Ruby 3.3.0 or 3.2.2?

[eregon]

Specifically I think what you are seeing is differences in parsing between 3.3 preview 1 and 3.3.0, there were many parse.y & lexer changes in between.
On older Ruby versions some tests are skipped.

[wenderjean]

@eregon Ruby 3.3.0 worked fine for me, thanks! Should I update the README?

[eregon]

Yes, that would be good, the README shouldn't mention previews, because previews should not be used at all anymore once the real release is out.

[eregon]

Although the only requirement to build the project is Ruby 3.0:

prism/prism.gemspec

Line 13 in 5ee9aeb

spec.required_ruby_version = ">= 3.0.0"

So it's probably best to specify that in the README.

[eregon]

(in either case open a PR and it'll get reviewed there)