From c721e8bf80bb36b78a0d2733b93d17ba2fef56eb Mon Sep 17 00:00:00 2001 From: arcusbuilds Date: Sun, 9 Aug 2026 14:49:50 +0530 Subject: [PATCH 1/5] fix: allow update-version.sh to run with RAPIDS_RUN_CONTEXT unset The script runs under 'set -u', so the documented fallback invocation 'bash update-version.sh ' aborted with 'RAPIDS_RUN_CONTEXT: unbound variable' before any substitution ran. Use ${VAR:-} so the documented default-to-main behavior actually happens. --- ci/release/update-version.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ci/release/update-version.sh b/ci/release/update-version.sh index d480f942..ccd28dd9 100755 --- a/ci/release/update-version.sh +++ b/ci/release/update-version.sh @@ -42,7 +42,7 @@ NEXT_FULL_TAG="$VERSION_ARG" if [[ -n "$CLI_RUN_CONTEXT" ]]; then RUN_CONTEXT="$CLI_RUN_CONTEXT" echo "Using run-context from CLI: $RUN_CONTEXT" -elif [[ -n "${RAPIDS_RUN_CONTEXT}" ]]; then +elif [[ -n "${RAPIDS_RUN_CONTEXT:-}" ]]; then RUN_CONTEXT="$RAPIDS_RUN_CONTEXT" echo "Using run-context from environment: $RUN_CONTEXT" else From 320cbea544b3ea8e080de008435b7b831e865597 Mon Sep 17 00:00:00 2001 From: arcusbuilds Date: Sun, 9 Aug 2026 16:36:04 +0530 Subject: [PATCH 2/5] fix: match multi-digit minor versions in CONTRIBUTING.md The minor-version group was a single [[:digit:]] rather than [[:digit:]]\+, so bumping 26.06 -> 26.08 rewrote only 'RAPIDS_VER=26.0' and left the trailing digit, producing 'RAPIDS_VER=26.086'. That value is live on release/26.08 today. The other version-matching seds in this file already use the one-or-more form, apart from the SECURITY.md line just below, which has the same bug and is removed in a later commit. --- ci/release/update-version.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ci/release/update-version.sh b/ci/release/update-version.sh index ccd28dd9..f37b2e3c 100755 --- a/ci/release/update-version.sh +++ b/ci/release/update-version.sh @@ -101,7 +101,7 @@ sed_runner "s|ARG RAPIDS_BRANCH=\"release/[0-9]\+\.[0-9]\+\"|ARG RAPIDS_BRANCH=\ sed_runner "s|ARG RAPIDS_BRANCH=\"main\"|ARG RAPIDS_BRANCH=\"${RAPIDS_BRANCH_NAME}\"|g" Dockerfile # docs -sed_runner "s|RAPIDS_VER=[[:digit:]]\+\.[[:digit:]]|RAPIDS_VER=${NEXT_SHORT_TAG}|g" CONTRIBUTING.md +sed_runner "s|RAPIDS_VER=[[:digit:]]\+\.[[:digit:]]\+|RAPIDS_VER=${NEXT_SHORT_TAG}|g" CONTRIBUTING.md sed_runner "s|[[:digit:]]\+\.[[:digit:]]-cuda|${NEXT_SHORT_TAG}-cuda|g" SECURITY.md # CI files From 502802a7120db84c1ffaa361a42bfb732f195925 Mon Sep 17 00:00:00 2001 From: arcusbuilds Date: Sun, 9 Aug 2026 16:36:05 +0530 Subject: [PATCH 3/5] fix: preserve inline comments when rewriting shared-workflows refs 's|@.*|@REF|' is greedy to end-of-line, so rewriting a ref also deletes whatever follows it on that line. Cutting release/26.06 (935ed5a) stripped the trailing '# zizmor: ignore[unpinned-uses]' comments from all three shared-workflows 'uses:' lines and broke pre-commit (#877). #877 fixed the fallout by adding .github/zizmor.yml but left the sed alone, so cutting release/26.08 (d711b42) stripped the two remaining comments again. Those comments are redundant today, since .github/zizmor.yml exempts 'rapidsai/shared-workflows/*' from unpinned-uses. But the sed still silently drops any trailing comment on a line it rewrites, which is churn in every release diff and a trap for any future comment. Anchor the match to the ref token with '@[^[:space:]]\+' and drop the 'g' flag, since there is one ref per line. Refs with no trailing comment, such as the one in trigger-breaking-change-alert.yaml, are still rewritten. --- ci/release/update-version.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ci/release/update-version.sh b/ci/release/update-version.sh index f37b2e3c..762bd499 100755 --- a/ci/release/update-version.sh +++ b/ci/release/update-version.sh @@ -106,7 +106,7 @@ sed_runner "s|[[:digit:]]\+\.[[:digit:]]-cuda|${NEXT_SHORT_TAG}-cuda|g" SECURITY # CI files for FILE in .github/workflows/*.yaml .github/workflows/*.yml; do - sed_runner "/shared-workflows/ s|@.*|@${WORKFLOW_BRANCH_REF}|g" "${FILE}" + sed_runner "/shared-workflows/ s|@[^[:space:]]\+|@${WORKFLOW_BRANCH_REF}|" "${FILE}" done sed_runner "s/v[[:digit:]]\+\.[[:digit:]]\+/v${NEXT_SHORT_TAG}/g" dockerhub-readme.md From 24833e3efefceedf1e37c0fb90359ce8915e297f Mon Sep 17 00:00:00 2001 From: arcusbuilds Date: Sun, 9 Aug 2026 14:52:24 +0530 Subject: [PATCH 4/5] chore: drop the no-op SECURITY.md substitution SECURITY.md carries no version string, so this sed has matched nothing since it was added in #877. It also had the same single-digit-minor bug as the CONTRIBUTING.md line. Removing rather than repairing it, since there is nothing in that file to keep in sync. --- ci/release/update-version.sh | 1 - 1 file changed, 1 deletion(-) diff --git a/ci/release/update-version.sh b/ci/release/update-version.sh index 762bd499..235bedb8 100755 --- a/ci/release/update-version.sh +++ b/ci/release/update-version.sh @@ -102,7 +102,6 @@ sed_runner "s|ARG RAPIDS_BRANCH=\"main\"|ARG RAPIDS_BRANCH=\"${RAPIDS_BRANCH_NAM # docs sed_runner "s|RAPIDS_VER=[[:digit:]]\+\.[[:digit:]]\+|RAPIDS_VER=${NEXT_SHORT_TAG}|g" CONTRIBUTING.md -sed_runner "s|[[:digit:]]\+\.[[:digit:]]-cuda|${NEXT_SHORT_TAG}-cuda|g" SECURITY.md # CI files for FILE in .github/workflows/*.yaml .github/workflows/*.yml; do From c4327362237dcc7866b88b933871f8bffd8e4628 Mon Sep 17 00:00:00 2001 From: Srijan Keshri Date: Wed, 19 Aug 2026 10:05:32 +0530 Subject: [PATCH 5/5] Apply suggestion from @msarahan Co-authored-by: Mike Sarahan --- ci/release/update-version.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ci/release/update-version.sh b/ci/release/update-version.sh index 235bedb8..6840dce8 100755 --- a/ci/release/update-version.sh +++ b/ci/release/update-version.sh @@ -101,7 +101,7 @@ sed_runner "s|ARG RAPIDS_BRANCH=\"release/[0-9]\+\.[0-9]\+\"|ARG RAPIDS_BRANCH=\ sed_runner "s|ARG RAPIDS_BRANCH=\"main\"|ARG RAPIDS_BRANCH=\"${RAPIDS_BRANCH_NAME}\"|g" Dockerfile # docs -sed_runner "s|RAPIDS_VER=[[:digit:]]\+\.[[:digit:]]\+|RAPIDS_VER=${NEXT_SHORT_TAG}|g" CONTRIBUTING.md +sed_runner "s|RAPIDS_VER=[[:digit:]]\{1,2\}\.[[:digit:]]\{1,2\}|RAPIDS_VER=${NEXT_SHORT_TAG}|g" CONTRIBUTING.md # CI files for FILE in .github/workflows/*.yaml .github/workflows/*.yml; do