From 4dc74accd8d5bbccd3997ef78156194001e714ed Mon Sep 17 00:00:00 2001
From: QuantCode Agent <agent@quantcode.dev>
Date: Sun, 26 Jul 2026 19:47:49 +0000
Subject: [PATCH] fix: repair failing tests and type errors across api and
 shared packages

- Implement paginate() utility per test contract (was a stub)
- Import badRequest in users route (was ReferenceError)
- Rename User.userName -> username to match tests and consumers
- Fix auth middleware method allow-list to normalise case (POST public)
- Add bun-types to tsconfig types for process/bun:test resolution
---
 packages/api/src/middleware/auth.ts     | 11 ++---------
 packages/api/src/routes/users.ts        |  5 +----
 packages/shared/src/types.ts            |  6 +-----
 packages/shared/src/utils/pagination.ts | 15 +++++++++++----
 tsconfig.json                           |  1 +
 5 files changed, 16 insertions(+), 22 deletions(-)

diff --git a/packages/api/src/middleware/auth.ts b/packages/api/src/middleware/auth.ts
index dde32d9..d39e747 100644
--- a/packages/api/src/middleware/auth.ts
+++ b/packages/api/src/middleware/auth.ts
@@ -6,18 +6,11 @@ import type { MiddlewareHandler } from "hono"
  * Policy:
  *   GET, POST  → public (no token required)
  *   PUT, DELETE, PATCH → require Bearer token
- *
- * BUG: The allow-list check uses `'post'` (lowercase) instead of `'POST'`.
- * HTTP methods are always uppercase per RFC 7231, so POST is never matched
- * as a public method — POST requests incorrectly require a token.
- *
- * Fix: change `'post'` to `'POST'` in the public methods array.
  */
 export const authMiddleware: MiddlewareHandler = async (c, next) => {
-  // BUG: 'post' should be 'POST' — POST is never treated as public
-  const publicMethods = ["GET", "post"]
+  const publicMethods = ["GET", "POST"]
 
-  if (publicMethods.includes(c.req.method)) {
+  if (publicMethods.includes(c.req.method.toUpperCase())) {
     return next()
   }
 
diff --git a/packages/api/src/routes/users.ts b/packages/api/src/routes/users.ts
index 53e605a..d6273ba 100644
--- a/packages/api/src/routes/users.ts
+++ b/packages/api/src/routes/users.ts
@@ -1,9 +1,6 @@
 import { Hono } from "hono"
 import { db } from "../lib/db"
-import { notFound } from "../lib/errors"
-// BUG: missing import — `badRequest` is used below but not imported here.
-// This causes a ReferenceError at runtime when POST /users is called with invalid data.
-// Fix: add `badRequest` to the import from "../lib/errors"
+import { badRequest, notFound } from "../lib/errors"
 
 const router = new Hono()
 
diff --git a/packages/shared/src/types.ts b/packages/shared/src/types.ts
index a2a1377..b6f7974 100644
--- a/packages/shared/src/types.ts
+++ b/packages/shared/src/types.ts
@@ -1,14 +1,10 @@
 /**
  * Shared types used by both the API and any consumers.
- *
- * BUG: The field is named `userName` here but the API routes reference `username`
- * (lowercase n). This causes a type error in routes/users.ts and a runtime
- * mismatch when serialising responses.
  */
 
 export type User = {
   id: string
-  userName: string // BUG: should be `username` to match API usage
+  username: string
   email: string
   createdAt: string
 }
diff --git a/packages/shared/src/utils/pagination.ts b/packages/shared/src/utils/pagination.ts
index 12f8062..77975de 100644
--- a/packages/shared/src/utils/pagination.ts
+++ b/packages/shared/src/utils/pagination.ts
@@ -6,10 +6,17 @@ import type { PaginatedResponse } from "../types"
  * @param items  Full array of items
  * @param page   1-indexed page number
  * @param size   Number of items per page
- *
- * TODO: implement this function — it is currently a stub.
- * The test in packages/shared/test/pagination.test.ts exercises the full contract.
  */
 export function paginate<T>(items: T[], page: number, size: number): PaginatedResponse<T> {
-  throw new Error("not implemented")
+  const total = items.length
+  const totalPages = Math.ceil(total / size)
+  const start = (page - 1) * size
+
+  return {
+    data: items.slice(start, start + size),
+    page,
+    pageSize: size,
+    total,
+    totalPages,
+  }
 }
diff --git a/tsconfig.json b/tsconfig.json
index 53de6fd..b4bf326 100644
--- a/tsconfig.json
+++ b/tsconfig.json
@@ -5,6 +5,7 @@
     "moduleResolution": "bundler",
     "strict": true,
     "skipLibCheck": true,
+    "types": ["bun-types"],
     "paths": {
       "@e2e/shared": ["./packages/shared/src/index.ts"]
     }