diff --git a/apps/web/src/lib/api.ts b/apps/web/src/lib/api.ts
index 2d4731b..ad85b26 100644
--- a/apps/web/src/lib/api.ts
+++ b/apps/web/src/lib/api.ts
@@ -1,14 +1,8 @@
/**
* API client utilities for the web app.
- *
- * BUG: imports `useThrottle` from @e2e/utils, but that hook was renamed to
- * `useDebounce`. This causes a TypeScript error and a runtime crash.
- *
- * Fix: change the import to `useDebounce`.
*/
-// BUG: useThrottle no longer exists — was renamed to useDebounce
-import { useThrottle } from "@e2e/utils"
+import { useDebounce } from "@e2e/utils"
import { formatDate, formatAUD } from "@e2e/utils"
export const BASE_URL = process.env.API_URL ?? "http://localhost:3000"
@@ -28,5 +22,5 @@ export async function fetchPosts() {
// Re-export formatting utilities used throughout the app
export { formatDate, formatAUD }
-// Re-export the debounce hook (currently broken import)
-export { useThrottle as useSearchDebounce }
+// Re-export the debounce hook under its stable public name
+export { useDebounce as useSearchDebounce }
diff --git a/packages/ui/src/components/Button/Button.tsx b/packages/ui/src/components/Button/Button.tsx
index af65c97..2d7f302 100644
--- a/packages/ui/src/components/Button/Button.tsx
+++ b/packages/ui/src/components/Button/Button.tsx
@@ -17,14 +17,13 @@ type Props = {
/**
* Button component.
*
- * BUG: When `iconOnly` is true, the button renders without visible text.
- * An `aria-label` is required for screen reader accessibility (WCAG 2.1 SC 4.1.2),
- * but the component does not enforce or warn about its absence.
- *
- * The test in Button.test.tsx checks that an icon-only button has an accessible name.
- * Fix: throw/warn in development when `iconOnly && !aria-label`, or always render
- * the aria-label attribute when iconOnly is true.
+ * Icon-only buttons have no visible text, so they must expose an accessible
+ * name via `aria-label` to satisfy WCAG 2.2 SC 4.1.2 (Name, Role, Value).
+ * When `iconOnly` is set we always render an `aria-label`, falling back to a
+ * generic name and warning in development if the caller omitted one.
*/
+const ICON_ONLY_FALLBACK_LABEL = "Button"
+
export function Button({
children,
icon,
@@ -34,15 +33,22 @@ export function Button({
onClick,
"aria-label": ariaLabel,
}: Props) {
+ if (process.env.NODE_ENV !== "production" && iconOnly && !ariaLabel) {
+ console.warn(
+ "Button: `iconOnly` buttons require an `aria-label` to provide an accessible name (WCAG 2.2 SC 4.1.2).",
+ )
+ }
+
+ const accessibleName = iconOnly ? ariaLabel ?? ICON_ONLY_FALLBACK_LABEL : ariaLabel
+
return (
)
diff --git a/packages/ui/src/components/DataTable/DataTable.tsx b/packages/ui/src/components/DataTable/DataTable.tsx
index 429a6e3..e6ba613 100644
--- a/packages/ui/src/components/DataTable/DataTable.tsx
+++ b/packages/ui/src/components/DataTable/DataTable.tsx
@@ -15,23 +15,14 @@ type Props> = {
/**
* DataTable with client-side sorting.
- *
- * BUG: The sort handler has a stale closure — it captures `sortDir` at the
- * time the handler is created, so toggling sort direction does not work
- * correctly after the first click. The second click always sorts in the same
- * direction as the first.
- *
- * Fix: use the functional form of setState — `setSortDir(prev => ...)` —
- * so the toggle always reads the current value.
*/
export function DataTable>({ data, columns }: Props) {
const [sortKey, setSortKey] = useState(null)
const [sortDir, setSortDir] = useState("asc")
- // BUG: stale closure — sortDir is captured at handler creation time
const handleSort = (key: keyof T) => {
if (sortKey === key) {
- setSortDir(sortDir === "asc" ? "desc" : "asc") // BUG: reads stale sortDir
+ setSortDir((prev) => (prev === "asc" ? "desc" : "asc"))
} else {
setSortKey(key)
setSortDir("asc")
diff --git a/packages/utils/src/format/date.ts b/packages/utils/src/format/date.ts
index 609e46c..981732b 100644
--- a/packages/utils/src/format/date.ts
+++ b/packages/utils/src/format/date.ts
@@ -1,20 +1,12 @@
/**
* Date formatting utilities.
*
- * BUG: formatDate passes `'en-AU'` as the locale but then uses a US-style
- * format string option (`month: 'numeric'` before `day: 'numeric'`), which
- * produces MM/DD/YYYY output instead of DD/MM/YYYY for Australian dates.
- *
- * Fix: use `dateStyle: 'short'` with `'en-AU'` locale, which correctly
- * produces DD/MM/YYYY, or explicitly set `day: 'numeric', month: 'numeric', year: 'numeric'`
- * and rely on the locale to order them correctly.
+ * Uses the `en-AU` locale so dates are rendered day-before-month, matching
+ * Australian Government conventions.
*/
export function formatDate(date: Date): string {
- // BUG: explicit field order overrides locale ordering — produces M/D/YYYY not D/M/YYYY
return new Intl.DateTimeFormat("en-AU", {
- month: "numeric",
- day: "numeric",
- year: "numeric",
+ dateStyle: "short",
}).format(date)
}