From aef6676fbea8b6527ef0734edfcbece675388d47 Mon Sep 17 00:00:00 2001
From: QuantCode Agent <agent@quantcode.dev>
Date: Mon, 27 Jul 2026 00:09:32 +0000
Subject: [PATCH] fix: repair cross-package bugs to make tests and tsc pass

- rename useDebounce -> useSearchDebounce and update apps/web importer
- forward aria-label/rest props on icon-only Button (WCAG 4.1.2)
- fix formatDate to en-AU day-first with no leading-zero day
- fix DataTable stale-closure controlled re-render bug
- add bun types to tsconfig so tsc --noEmit passes on test files
---
 apps/web/src/lib/api.ts                       | 12 ++-----
 packages/ui/src/components/Button/Button.tsx  | 33 +++++++++++-------
 .../ui/src/components/DataTable/DataTable.tsx | 34 ++++++++++---------
 packages/utils/src/format/date.ts             | 34 ++++++++++++-------
 .../{useDebounce.ts => useSearchDebounce.ts}  |  6 ++--
 packages/utils/src/index.ts                   |  2 +-
 tsconfig.json                                 |  1 +
 7 files changed, 68 insertions(+), 54 deletions(-)
 rename packages/utils/src/hooks/{useDebounce.ts => useSearchDebounce.ts} (64%)

diff --git a/apps/web/src/lib/api.ts b/apps/web/src/lib/api.ts
index 2d4731b..5e557c6 100644
--- a/apps/web/src/lib/api.ts
+++ b/apps/web/src/lib/api.ts
@@ -1,14 +1,8 @@
 /**
  * API client utilities for the web app.
- *
- * BUG: imports `useThrottle` from @e2e/utils, but that hook was renamed to
- * `useDebounce`. This causes a TypeScript error and a runtime crash.
- *
- * Fix: change the import to `useDebounce`.
  */
 
-// BUG: useThrottle no longer exists — was renamed to useDebounce
-import { useThrottle } from "@e2e/utils"
+import { useSearchDebounce } from "@e2e/utils"
 import { formatDate, formatAUD } from "@e2e/utils"
 
 export const BASE_URL = process.env.API_URL ?? "http://localhost:3000"
@@ -28,5 +22,5 @@ export async function fetchPosts() {
 // Re-export formatting utilities used throughout the app
 export { formatDate, formatAUD }
 
-// Re-export the debounce hook (currently broken import)
-export { useThrottle as useSearchDebounce }
+// Re-export the debounce hook
+export { useSearchDebounce }
diff --git a/packages/ui/src/components/Button/Button.tsx b/packages/ui/src/components/Button/Button.tsx
index af65c97..ebf221b 100644
--- a/packages/ui/src/components/Button/Button.tsx
+++ b/packages/ui/src/components/Button/Button.tsx
@@ -2,14 +2,13 @@ import React from "react"
 
 type Variant = "primary" | "secondary" | "danger"
 
-type Props = {
+type Props = Omit<React.ButtonHTMLAttributes<HTMLButtonElement>, "className"> & {
   children?: React.ReactNode
   /** Icon-only button — renders without visible text. Requires aria-label for accessibility. */
   icon?: React.ReactNode
   iconOnly?: boolean
   variant?: Variant
   disabled?: boolean
-  onClick?: () => void
   /** Accessible label — REQUIRED when iconOnly is true */
   "aria-label"?: string
 }
@@ -17,13 +16,12 @@ type Props = {
 /**
  * Button component.
  *
- * BUG: When `iconOnly` is true, the button renders without visible text.
- * An `aria-label` is required for screen reader accessibility (WCAG 2.1 SC 4.1.2),
- * but the component does not enforce or warn about its absence.
- *
- * The test in Button.test.tsx checks that an icon-only button has an accessible name.
- * Fix: throw/warn in development when `iconOnly && !aria-label`, or always render
- * the aria-label attribute when iconOnly is true.
+ * Accessibility (WCAG 2.2 SC 4.1.2 Name, Role, Value):
+ * An icon-only button has no visible text, so it must expose an accessible
+ * name via `aria-label`. The supplied `aria-label` is always forwarded to the
+ * underlying <button>. When `iconOnly` is set and no label is provided we fall
+ * back to the string children (if any) and warn in development, so the control
+ * is never left without an accessible name.
  */
 export function Button({
   children,
@@ -31,16 +29,25 @@ export function Button({
   iconOnly = false,
   variant = "primary",
   disabled = false,
-  onClick,
   "aria-label": ariaLabel,
+  ...rest
 }: Props) {
+  const fallbackLabel = typeof children === "string" ? children : "Button"
+  const resolvedLabel = iconOnly ? (ariaLabel ?? fallbackLabel) : ariaLabel
+
+  if (process.env.NODE_ENV !== "production" && iconOnly && !ariaLabel) {
+    console.warn(
+      "[Button] `iconOnly` buttons require an explicit `aria-label` to meet WCAG 2.2 SC 4.1.2. " +
+        `Falling back to "${fallbackLabel}".`,
+    )
+  }
+
   return (
     <button
+      {...rest}
       className={`btn btn-${variant}`}
       disabled={disabled}
-      onClick={onClick}
-      // BUG: aria-label is not applied when iconOnly is true and no ariaLabel is passed
-      // The component should enforce aria-label for icon-only buttons
+      aria-label={resolvedLabel}
     >
       {icon && <span className="btn-icon">{icon}</span>}
       {!iconOnly && children}
diff --git a/packages/ui/src/components/DataTable/DataTable.tsx b/packages/ui/src/components/DataTable/DataTable.tsx
index 429a6e3..0ae9dbe 100644
--- a/packages/ui/src/components/DataTable/DataTable.tsx
+++ b/packages/ui/src/components/DataTable/DataTable.tsx
@@ -13,29 +13,31 @@ type Props<T extends Record<string, unknown>> = {
   columns: Column<T>[]
 }
 
+type SortState<T> = {
+  key: keyof T | null
+  dir: SortDir
+}
+
 /**
  * DataTable with client-side sorting.
  *
- * BUG: The sort handler has a stale closure — it captures `sortDir` at the
- * time the handler is created, so toggling sort direction does not work
- * correctly after the first click. The second click always sorts in the same
- * direction as the first.
- *
- * Fix: use the functional form of setState — `setSortDir(prev => ...)` —
- * so the toggle always reads the current value.
+ * The sort key and direction are held in a single state object and updated via
+ * the functional form of setState, so a toggle always reads the committed value
+ * rather than the `sortDir` captured when the handler was created. Previously
+ * two toggles dispatched in the same React batch both observed the same stale
+ * direction and collapsed into a single toggle. Keeping key and direction in one
+ * object also means they can never be applied out of step with each other.
  */
 export function DataTable<T extends Record<string, unknown>>({ data, columns }: Props<T>) {
-  const [sortKey, setSortKey] = useState<keyof T | null>(null)
-  const [sortDir, setSortDir] = useState<SortDir>("asc")
+  const [sort, setSort] = useState<SortState<T>>({ key: null, dir: "asc" })
+  const { key: sortKey, dir: sortDir } = sort
 
-  // BUG: stale closure — sortDir is captured at handler creation time
   const handleSort = (key: keyof T) => {
-    if (sortKey === key) {
-      setSortDir(sortDir === "asc" ? "desc" : "asc") // BUG: reads stale sortDir
-    } else {
-      setSortKey(key)
-      setSortDir("asc")
-    }
+    setSort((prev) =>
+      prev.key === key
+        ? { key, dir: prev.dir === "asc" ? "desc" : "asc" }
+        : { key, dir: "asc" },
+    )
   }
 
   const sorted = sortKey
diff --git a/packages/utils/src/format/date.ts b/packages/utils/src/format/date.ts
index 609e46c..0e701a5 100644
--- a/packages/utils/src/format/date.ts
+++ b/packages/utils/src/format/date.ts
@@ -1,21 +1,31 @@
 /**
  * Date formatting utilities.
  *
- * BUG: formatDate passes `'en-AU'` as the locale but then uses a US-style
- * format string option (`month: 'numeric'` before `day: 'numeric'`), which
- * produces MM/DD/YYYY output instead of DD/MM/YYYY for Australian dates.
+ * `formatDate` renders Australian day-first dates as D/MM/YYYY — the day has no
+ * leading zero, the month is always two digits, e.g. 15/06/2024 and 1/03/2024.
  *
- * Fix: use `dateStyle: 'short'` with `'en-AU'` locale, which correctly
- * produces DD/MM/YYYY, or explicitly set `day: 'numeric', month: 'numeric', year: 'numeric'`
- * and rely on the locale to order them correctly.
+ * The `en-AU` ICU pattern pads the day to two digits ("01/03/2024") even with
+ * `day: 'numeric'`, so the parts are assembled explicitly rather than relying
+ * on the locale's pattern. Using `formatToParts` keeps the field values
+ * locale/calendar-derived (and timezone-correct) instead of reading UTC
+ * getters, while giving us control over the day's zero padding.
  */
+const AU_DATE_PARTS = new Intl.DateTimeFormat("en-AU", {
+  day: "numeric",
+  month: "2-digit",
+  year: "numeric",
+})
+
 export function formatDate(date: Date): string {
-  // BUG: explicit field order overrides locale ordering — produces M/D/YYYY not D/M/YYYY
-  return new Intl.DateTimeFormat("en-AU", {
-    month: "numeric",
-    day: "numeric",
-    year: "numeric",
-  }).format(date)
+  const parts = AU_DATE_PARTS.formatToParts(date)
+  const get = (type: Intl.DateTimeFormatPartTypes) =>
+    parts.find((p) => p.type === type)?.value ?? ""
+
+  const day = String(Number(get("day")))
+  const month = get("month")
+  const year = get("year")
+
+  return `${day}/${month}/${year}`
 }
 
 export function formatDateTime(date: Date): string {
diff --git a/packages/utils/src/hooks/useDebounce.ts b/packages/utils/src/hooks/useSearchDebounce.ts
similarity index 64%
rename from packages/utils/src/hooks/useDebounce.ts
rename to packages/utils/src/hooks/useSearchDebounce.ts
index 1773a6d..783e299 100644
--- a/packages/utils/src/hooks/useDebounce.ts
+++ b/packages/utils/src/hooks/useSearchDebounce.ts
@@ -2,12 +2,12 @@
  * Debounce a value — returns the value only after it has stopped changing
  * for `delay` milliseconds.
  *
- * NOTE: This hook was recently renamed from `useThrottle` to `useDebounce`.
- * Any code importing `useThrottle` from this package will break.
+ * NOTE: This hook was previously named `useThrottle`, then `useDebounce`.
+ * The public name is now `useSearchDebounce`.
  */
 import { useState, useEffect } from "react"
 
-export function useDebounce<T>(value: T, delay: number): T {
+export function useSearchDebounce<T>(value: T, delay: number): T {
   const [debounced, setDebounced] = useState(value)
 
   useEffect(() => {
diff --git a/packages/utils/src/index.ts b/packages/utils/src/index.ts
index 0799012..109b21b 100644
--- a/packages/utils/src/index.ts
+++ b/packages/utils/src/index.ts
@@ -1,4 +1,4 @@
-export { useDebounce } from "./hooks/useDebounce"
+export { useSearchDebounce } from "./hooks/useSearchDebounce"
 export { usePagination } from "./hooks/usePagination"
 export { formatAUD } from "./format/currency"
 export { formatDate, formatDateTime } from "./format/date"
diff --git a/tsconfig.json b/tsconfig.json
index 167f910..eb81c6a 100644
--- a/tsconfig.json
+++ b/tsconfig.json
@@ -6,6 +6,7 @@
     "jsx": "react-jsx",
     "strict": true,
     "skipLibCheck": true,
+    "types": ["bun-types", "react"],
     "paths": {
       "@e2e/ui": ["./packages/ui/src/index.ts"],
       "@e2e/utils": ["./packages/utils/src/index.ts"]