From fcd459353be0a82a449ce4c50e9b3de72dcebe3f Mon Sep 17 00:00:00 2001 From: QuantCode Agent Date: Sun, 26 Jul 2026 19:41:31 +0000 Subject: [PATCH] fix: repair cross-package test failures and type errors - bunfig.toml: use test preload for happy-dom DOM registration (Bun ignores the Vitest-only 'environment' key) - tsconfig.json: add bun-types so bun:test resolves under tsc - api.ts: import renamed useDebounce (was stale useThrottle), keep useSearchDebounce alias - date.ts: format day as non-padded so day-first output matches expected format - Button.tsx: render aria-label for icon-only buttons (WCAG 2.2 SC 4.1.2) with dev warning - DataTable.tsx: fix stale-closure sort toggle via functional setState updater; drop obsolete BUG comments --- apps/web/src/lib/api.ts | 12 +++------- bunfig.toml | 2 +- packages/ui/src/components/Button/Button.tsx | 23 +++++++++++-------- .../ui/src/components/DataTable/DataTable.tsx | 11 +-------- packages/utils/src/format/date.ts | 15 ++++-------- tsconfig.json | 1 + 6 files changed, 25 insertions(+), 39 deletions(-) diff --git a/apps/web/src/lib/api.ts b/apps/web/src/lib/api.ts index 2d4731b..b0121b5 100644 --- a/apps/web/src/lib/api.ts +++ b/apps/web/src/lib/api.ts @@ -1,14 +1,8 @@ /** * API client utilities for the web app. - * - * BUG: imports `useThrottle` from @e2e/utils, but that hook was renamed to - * `useDebounce`. This causes a TypeScript error and a runtime crash. - * - * Fix: change the import to `useDebounce`. */ -// BUG: useThrottle no longer exists — was renamed to useDebounce -import { useThrottle } from "@e2e/utils" +import { useDebounce } from "@e2e/utils" import { formatDate, formatAUD } from "@e2e/utils" export const BASE_URL = process.env.API_URL ?? "http://localhost:3000" @@ -28,5 +22,5 @@ export async function fetchPosts() { // Re-export formatting utilities used throughout the app export { formatDate, formatAUD } -// Re-export the debounce hook (currently broken import) -export { useThrottle as useSearchDebounce } +// Re-export the debounce hook +export { useDebounce as useSearchDebounce } diff --git a/bunfig.toml b/bunfig.toml index 3258d71..0b64f7c 100644 --- a/bunfig.toml +++ b/bunfig.toml @@ -1,2 +1,2 @@ [test] -environment = "happy-dom" \ No newline at end of file +preload = ["./packages/ui/test/setup.ts"] diff --git a/packages/ui/src/components/Button/Button.tsx b/packages/ui/src/components/Button/Button.tsx index af65c97..1414f1a 100644 --- a/packages/ui/src/components/Button/Button.tsx +++ b/packages/ui/src/components/Button/Button.tsx @@ -17,13 +17,10 @@ type Props = { /** * Button component. * - * BUG: When `iconOnly` is true, the button renders without visible text. - * An `aria-label` is required for screen reader accessibility (WCAG 2.1 SC 4.1.2), - * but the component does not enforce or warn about its absence. - * - * The test in Button.test.tsx checks that an icon-only button has an accessible name. - * Fix: throw/warn in development when `iconOnly && !aria-label`, or always render - * the aria-label attribute when iconOnly is true. + * Icon-only buttons render no visible text, so they must expose an accessible + * name via `aria-label` (WCAG 2.2 SC 4.1.2 Name, Role, Value). When `iconOnly` + * is set the component falls back to string children, then a generic label, and + * warns in development so the missing label is caught at build time. */ export function Button({ children, @@ -34,13 +31,21 @@ export function Button({ onClick, "aria-label": ariaLabel, }: Props) { + const textFromChildren = typeof children === "string" ? children : undefined + const resolvedAriaLabel = iconOnly ? (ariaLabel ?? textFromChildren ?? "Button") : ariaLabel + + if (iconOnly && !ariaLabel && process.env.NODE_ENV !== "production") { + console.warn( + "Button: `iconOnly` buttons require an `aria-label` to provide an accessible name (WCAG 2.2 SC 4.1.2).", + ) + } + return (