diff --git a/apps/web/src/lib/api.ts b/apps/web/src/lib/api.ts index 2d4731b..4df4cfc 100644 --- a/apps/web/src/lib/api.ts +++ b/apps/web/src/lib/api.ts @@ -8,7 +8,7 @@ */ // BUG: useThrottle no longer exists — was renamed to useDebounce -import { useThrottle } from "@e2e/utils" +import { useDebounce } from "@e2e/utils" import { formatDate, formatAUD } from "@e2e/utils" export const BASE_URL = process.env.API_URL ?? "http://localhost:3000" @@ -29,4 +29,4 @@ export async function fetchPosts() { export { formatDate, formatAUD } // Re-export the debounce hook (currently broken import) -export { useThrottle as useSearchDebounce } +export { useDebounce as useSearchDebounce } diff --git a/packages/ui/src/components/Button/Button.tsx b/packages/ui/src/components/Button/Button.tsx index af65c97..a96a223 100644 --- a/packages/ui/src/components/Button/Button.tsx +++ b/packages/ui/src/components/Button/Button.tsx @@ -2,29 +2,13 @@ import React from "react" type Variant = "primary" | "secondary" | "danger" -type Props = { +type Props = React.ButtonHTMLAttributes & { children?: React.ReactNode - /** Icon-only button — renders without visible text. Requires aria-label for accessibility. */ icon?: React.ReactNode iconOnly?: boolean variant?: Variant - disabled?: boolean - onClick?: () => void - /** Accessible label — REQUIRED when iconOnly is true */ - "aria-label"?: string } -/** - * Button component. - * - * BUG: When `iconOnly` is true, the button renders without visible text. - * An `aria-label` is required for screen reader accessibility (WCAG 2.1 SC 4.1.2), - * but the component does not enforce or warn about its absence. - * - * The test in Button.test.tsx checks that an icon-only button has an accessible name. - * Fix: throw/warn in development when `iconOnly && !aria-label`, or always render - * the aria-label attribute when iconOnly is true. - */ export function Button({ children, icon, @@ -33,14 +17,17 @@ export function Button({ disabled = false, onClick, "aria-label": ariaLabel, + ...rest }: Props) { + const resolvedAriaLabel = iconOnly ? (ariaLabel ?? "button") : ariaLabel + return (