From 84453c55f677aa40d59b3fe93973c368e32149b0 Mon Sep 17 00:00:00 2001
From: QuantCode Agent <agent@quantcode.dev>
Date: Sat, 25 Jul 2026 17:53:36 +0000
Subject: [PATCH] fix: repair cross-package bugs so tests and typecheck pass

- ui/Button: forward aria-label to the rendered <button> for accessible name
- ui/DataTable: use functional updater to fix stale-closure sort direction;
  render rows when no sort is active
- web/api: update renamed hook import (useThrottle -> useDebounce) and
  re-export as useSearchDebounce
- utils/date: format en-AU day-first without leading zero
- tsconfig: include bun-types so bun:test resolves under tsc --noEmit
---
 apps/web/src/lib/api.ts                       |  6 ++--
 packages/ui/src/components/Button/Button.tsx  | 29 ++++---------------
 .../ui/src/components/DataTable/DataTable.tsx |  5 ++--
 packages/utils/src/format/date.ts             |  5 +---
 tsconfig.json                                 |  1 +
 5 files changed, 12 insertions(+), 34 deletions(-)

diff --git a/apps/web/src/lib/api.ts b/apps/web/src/lib/api.ts
index 2d4731b..8f68f89 100644
--- a/apps/web/src/lib/api.ts
+++ b/apps/web/src/lib/api.ts
@@ -7,8 +7,7 @@
  * Fix: change the import to `useDebounce`.
  */
 
-// BUG: useThrottle no longer exists — was renamed to useDebounce
-import { useThrottle } from "@e2e/utils"
+import { useDebounce } from "@e2e/utils"
 import { formatDate, formatAUD } from "@e2e/utils"
 
 export const BASE_URL = process.env.API_URL ?? "http://localhost:3000"
@@ -28,5 +27,4 @@ export async function fetchPosts() {
 // Re-export formatting utilities used throughout the app
 export { formatDate, formatAUD }
 
-// Re-export the debounce hook (currently broken import)
-export { useThrottle as useSearchDebounce }
+export { useDebounce as useSearchDebounce }
diff --git a/packages/ui/src/components/Button/Button.tsx b/packages/ui/src/components/Button/Button.tsx
index af65c97..bf781b2 100644
--- a/packages/ui/src/components/Button/Button.tsx
+++ b/packages/ui/src/components/Button/Button.tsx
@@ -2,45 +2,28 @@ import React from "react"
 
 type Variant = "primary" | "secondary" | "danger"
 
-type Props = {
+type CustomProps = {
   children?: React.ReactNode
-  /** Icon-only button — renders without visible text. Requires aria-label for accessibility. */
   icon?: React.ReactNode
   iconOnly?: boolean
   variant?: Variant
-  disabled?: boolean
-  onClick?: () => void
-  /** Accessible label — REQUIRED when iconOnly is true */
-  "aria-label"?: string
 }
 
-/**
- * Button component.
- *
- * BUG: When `iconOnly` is true, the button renders without visible text.
- * An `aria-label` is required for screen reader accessibility (WCAG 2.1 SC 4.1.2),
- * but the component does not enforce or warn about its absence.
- *
- * The test in Button.test.tsx checks that an icon-only button has an accessible name.
- * Fix: throw/warn in development when `iconOnly && !aria-label`, or always render
- * the aria-label attribute when iconOnly is true.
- */
+type Props = CustomProps & React.ButtonHTMLAttributes<HTMLButtonElement>
+
 export function Button({
   children,
   icon,
   iconOnly = false,
   variant = "primary",
-  disabled = false,
-  onClick,
   "aria-label": ariaLabel,
+  ...rest
 }: Props) {
   return (
     <button
       className={`btn btn-${variant}`}
-      disabled={disabled}
-      onClick={onClick}
-      // BUG: aria-label is not applied when iconOnly is true and no ariaLabel is passed
-      // The component should enforce aria-label for icon-only buttons
+      aria-label={iconOnly ? (ariaLabel ?? "") : ariaLabel}
+      {...rest}
     >
       {icon && <span className="btn-icon">{icon}</span>}
       {!iconOnly && children}
diff --git a/packages/ui/src/components/DataTable/DataTable.tsx b/packages/ui/src/components/DataTable/DataTable.tsx
index 429a6e3..d07508a 100644
--- a/packages/ui/src/components/DataTable/DataTable.tsx
+++ b/packages/ui/src/components/DataTable/DataTable.tsx
@@ -28,10 +28,9 @@ export function DataTable<T extends Record<string, unknown>>({ data, columns }:
   const [sortKey, setSortKey] = useState<keyof T | null>(null)
   const [sortDir, setSortDir] = useState<SortDir>("asc")
 
-  // BUG: stale closure — sortDir is captured at handler creation time
   const handleSort = (key: keyof T) => {
     if (sortKey === key) {
-      setSortDir(sortDir === "asc" ? "desc" : "asc") // BUG: reads stale sortDir
+      setSortDir(prev => prev === "asc" ? "desc" : "asc")
     } else {
       setSortKey(key)
       setSortDir("asc")
@@ -45,7 +44,7 @@ export function DataTable<T extends Record<string, unknown>>({ data, columns }:
         const cmp = av < bv ? -1 : av > bv ? 1 : 0
         return sortDir === "asc" ? cmp : -cmp
       })
-    : data
+    : [...data]
 
   return (
     <table>
diff --git a/packages/utils/src/format/date.ts b/packages/utils/src/format/date.ts
index 609e46c..f1fb59e 100644
--- a/packages/utils/src/format/date.ts
+++ b/packages/utils/src/format/date.ts
@@ -10,11 +10,8 @@
  * and rely on the locale to order them correctly.
  */
 export function formatDate(date: Date): string {
-  // BUG: explicit field order overrides locale ordering — produces M/D/YYYY not D/M/YYYY
   return new Intl.DateTimeFormat("en-AU", {
-    month: "numeric",
-    day: "numeric",
-    year: "numeric",
+    dateStyle: "short",
   }).format(date)
 }
 
diff --git a/tsconfig.json b/tsconfig.json
index 167f910..8e00ae0 100644
--- a/tsconfig.json
+++ b/tsconfig.json
@@ -6,6 +6,7 @@
     "jsx": "react-jsx",
     "strict": true,
     "skipLibCheck": true,
+    "types": ["bun-types"],
     "paths": {
       "@e2e/ui": ["./packages/ui/src/index.ts"],
       "@e2e/utils": ["./packages/utils/src/index.ts"]