From c7a448f9783ef04e578a549157b80bafa0ad91eb Mon Sep 17 00:00:00 2001 From: QuantCode Agent Date: Thu, 23 Jul 2026 16:50:58 +0000 Subject: [PATCH] fix: repair cross-package bugs so tests and tsc pass - api.ts: import renamed hook useDebounce (was useThrottle) from @e2e/utils - Button: pass aria-label through so icon-only buttons expose an accessible name - DataTable: use functional updater in sort toggle to fix stale-closure bug - date.ts: use en-AU day-first numeric-day format (1/03/2024 not 01/03/2024) - bunfig.toml: run UI tests under happy-dom so `document` is defined - tsconfig.json: add bun-types so tsc resolves the bun:test module --- apps/web/src/lib/api.ts | 6 ++---- bunfig.toml | 3 ++- packages/ui/bunfig.toml | 3 ++- packages/ui/src/components/Button/Button.tsx | 11 +---------- packages/ui/src/components/DataTable/DataTable.tsx | 11 +---------- packages/utils/src/format/date.ts | 13 ++----------- tsconfig.json | 1 + 7 files changed, 11 insertions(+), 37 deletions(-) diff --git a/apps/web/src/lib/api.ts b/apps/web/src/lib/api.ts index 2d4731b..8f68f89 100644 --- a/apps/web/src/lib/api.ts +++ b/apps/web/src/lib/api.ts @@ -7,8 +7,7 @@ * Fix: change the import to `useDebounce`. */ -// BUG: useThrottle no longer exists — was renamed to useDebounce -import { useThrottle } from "@e2e/utils" +import { useDebounce } from "@e2e/utils" import { formatDate, formatAUD } from "@e2e/utils" export const BASE_URL = process.env.API_URL ?? "http://localhost:3000" @@ -28,5 +27,4 @@ export async function fetchPosts() { // Re-export formatting utilities used throughout the app export { formatDate, formatAUD } -// Re-export the debounce hook (currently broken import) -export { useThrottle as useSearchDebounce } +export { useDebounce as useSearchDebounce } diff --git a/bunfig.toml b/bunfig.toml index 3258d71..26b14f2 100644 --- a/bunfig.toml +++ b/bunfig.toml @@ -1,2 +1,3 @@ [test] -environment = "happy-dom" \ No newline at end of file +environment = "happy-dom" +preload = ["./packages/ui/test/setup.ts"] \ No newline at end of file diff --git a/packages/ui/bunfig.toml b/packages/ui/bunfig.toml index 54ef11c..95e90aa 100644 --- a/packages/ui/bunfig.toml +++ b/packages/ui/bunfig.toml @@ -1,2 +1,3 @@ [test] -preload = ["./test/setup.ts"] \ No newline at end of file +preload = ["./test/setup.ts"] +environment = "happy-dom" \ No newline at end of file diff --git a/packages/ui/src/components/Button/Button.tsx b/packages/ui/src/components/Button/Button.tsx index af65c97..2cf568d 100644 --- a/packages/ui/src/components/Button/Button.tsx +++ b/packages/ui/src/components/Button/Button.tsx @@ -16,14 +16,6 @@ type Props = { /** * Button component. - * - * BUG: When `iconOnly` is true, the button renders without visible text. - * An `aria-label` is required for screen reader accessibility (WCAG 2.1 SC 4.1.2), - * but the component does not enforce or warn about its absence. - * - * The test in Button.test.tsx checks that an icon-only button has an accessible name. - * Fix: throw/warn in development when `iconOnly && !aria-label`, or always render - * the aria-label attribute when iconOnly is true. */ export function Button({ children, @@ -39,8 +31,7 @@ export function Button({ className={`btn btn-${variant}`} disabled={disabled} onClick={onClick} - // BUG: aria-label is not applied when iconOnly is true and no ariaLabel is passed - // The component should enforce aria-label for icon-only buttons + aria-label={iconOnly ? (ariaLabel ?? "") : ariaLabel} > {icon && {icon}} {!iconOnly && children} diff --git a/packages/ui/src/components/DataTable/DataTable.tsx b/packages/ui/src/components/DataTable/DataTable.tsx index 429a6e3..785a36d 100644 --- a/packages/ui/src/components/DataTable/DataTable.tsx +++ b/packages/ui/src/components/DataTable/DataTable.tsx @@ -15,23 +15,14 @@ type Props> = { /** * DataTable with client-side sorting. - * - * BUG: The sort handler has a stale closure — it captures `sortDir` at the - * time the handler is created, so toggling sort direction does not work - * correctly after the first click. The second click always sorts in the same - * direction as the first. - * - * Fix: use the functional form of setState — `setSortDir(prev => ...)` — - * so the toggle always reads the current value. */ export function DataTable>({ data, columns }: Props) { const [sortKey, setSortKey] = useState(null) const [sortDir, setSortDir] = useState("asc") - // BUG: stale closure — sortDir is captured at handler creation time const handleSort = (key: keyof T) => { if (sortKey === key) { - setSortDir(sortDir === "asc" ? "desc" : "asc") // BUG: reads stale sortDir + setSortDir(prev => (prev === "asc" ? "desc" : "asc")) } else { setSortKey(key) setSortDir("asc") diff --git a/packages/utils/src/format/date.ts b/packages/utils/src/format/date.ts index 609e46c..d9ba9f0 100644 --- a/packages/utils/src/format/date.ts +++ b/packages/utils/src/format/date.ts @@ -1,21 +1,12 @@ /** * Date formatting utilities. - * - * BUG: formatDate passes `'en-AU'` as the locale but then uses a US-style - * format string option (`month: 'numeric'` before `day: 'numeric'`), which - * produces MM/DD/YYYY output instead of DD/MM/YYYY for Australian dates. - * - * Fix: use `dateStyle: 'short'` with `'en-AU'` locale, which correctly - * produces DD/MM/YYYY, or explicitly set `day: 'numeric', month: 'numeric', year: 'numeric'` - * and rely on the locale to order them correctly. */ export function formatDate(date: Date): string { - // BUG: explicit field order overrides locale ordering — produces M/D/YYYY not D/M/YYYY return new Intl.DateTimeFormat("en-AU", { - month: "numeric", day: "numeric", + month: "2-digit", year: "numeric", - }).format(date) + }).format(date).replace(/^0/, "") } export function formatDateTime(date: Date): string { diff --git a/tsconfig.json b/tsconfig.json index 167f910..8e00ae0 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -6,6 +6,7 @@ "jsx": "react-jsx", "strict": true, "skipLibCheck": true, + "types": ["bun-types"], "paths": { "@e2e/ui": ["./packages/ui/src/index.ts"], "@e2e/utils": ["./packages/utils/src/index.ts"]