diff --git a/apps/web/src/lib/api.ts b/apps/web/src/lib/api.ts index 2d4731b..8a635e5 100644 --- a/apps/web/src/lib/api.ts +++ b/apps/web/src/lib/api.ts @@ -1,15 +1,8 @@ /** * API client utilities for the web app. - * - * BUG: imports `useThrottle` from @e2e/utils, but that hook was renamed to - * `useDebounce`. This causes a TypeScript error and a runtime crash. - * - * Fix: change the import to `useDebounce`. */ -// BUG: useThrottle no longer exists — was renamed to useDebounce -import { useThrottle } from "@e2e/utils" -import { formatDate, formatAUD } from "@e2e/utils" +import { useDebounce, formatDate, formatAUD } from "@e2e/utils" export const BASE_URL = process.env.API_URL ?? "http://localhost:3000" @@ -28,5 +21,5 @@ export async function fetchPosts() { // Re-export formatting utilities used throughout the app export { formatDate, formatAUD } -// Re-export the debounce hook (currently broken import) -export { useThrottle as useSearchDebounce } +// Re-export the debounce hook +export { useDebounce as useSearchDebounce } diff --git a/bunfig.toml b/bunfig.toml index 3258d71..376bf35 100644 --- a/bunfig.toml +++ b/bunfig.toml @@ -1,2 +1,6 @@ +# `environment = "happy-dom"` is a Jest/Vitest concept — Bun has no such [test] +# option and silently ignores it, which left `document` undefined for the React +# component tests. Registering happy-dom via a preload script is what actually +# installs the DOM globals. [test] -environment = "happy-dom" \ No newline at end of file +preload = ["./packages/ui/test/setup.ts"] diff --git a/packages/ui/src/components/Button/Button.tsx b/packages/ui/src/components/Button/Button.tsx index af65c97..7edc37c 100644 --- a/packages/ui/src/components/Button/Button.tsx +++ b/packages/ui/src/components/Button/Button.tsx @@ -14,16 +14,22 @@ type Props = { "aria-label"?: string } +/** + * Fallback accessible name for an icon-only button whose author supplied no + * `aria-label`. This is a last-resort floor so the control is never left with no + * accessible name at all (WCAG 2.2 AA SC 4.1.2) — it is deliberately generic and + * is NOT a substitute for a meaningful label, hence the development warning. + */ +const ICON_ONLY_FALLBACK_LABEL = "Button" + /** * Button component. * - * BUG: When `iconOnly` is true, the button renders without visible text. - * An `aria-label` is required for screen reader accessibility (WCAG 2.1 SC 4.1.2), - * but the component does not enforce or warn about its absence. - * - * The test in Button.test.tsx checks that an icon-only button has an accessible name. - * Fix: throw/warn in development when `iconOnly && !aria-label`, or always render - * the aria-label attribute when iconOnly is true. + * Accessibility: an icon-only button has no visible text, so its accessible name + * must come from `aria-label` (WCAG 2.2 AA SC 4.1.2 Name, Role, Value). For + * buttons that do render text we leave `aria-label` unset so the visible label + * remains the accessible name — overriding it would break SC 2.5.3 (Label in + * Name). */ export function Button({ children, @@ -34,13 +40,20 @@ export function Button({ onClick, "aria-label": ariaLabel, }: Props) { + if (process.env.NODE_ENV !== "production" && iconOnly && !ariaLabel) { + console.warn( + "Button: `iconOnly` buttons have no visible text, so they require an " + + "`aria-label` describing the action (WCAG 2.2 AA SC 4.1.2). Falling back " + + `to "${ICON_ONLY_FALLBACK_LABEL}", which is not a meaningful label.`, + ) + } + return (