From 46eed1f70be5e90730dfd9407171ebc880c4af31 Mon Sep 17 00:00:00 2001
From: QuantCode Agent <agent@quantcode.dev>
Date: Thu, 30 Jul 2026 16:57:54 +0000
Subject: [PATCH] fix: repair cross-package test failures and type errors

- restore useSearchDebounce export alias (hook renamed to useDebounce)
- preload happy-dom in root bunfig.toml so component tests have a DOM
- forward aria-label and default it for iconOnly Buttons (WCAG 4.1.2)
- format dates day-first with unpadded day and 4-digit year (en-AU)
- add DOM/test types in tsconfig so tsc --noEmit is clean
---
 apps/web/src/lib/api.ts                      | 14 ++++----
 bunfig.toml                                  |  2 +-
 packages/ui/src/components/Button/Button.tsx | 29 ++++++++++-----
 packages/utils/src/format/date.ts            | 38 +++++++++++---------
 tsconfig.json                                |  1 +
 5 files changed, 50 insertions(+), 34 deletions(-)

diff --git a/apps/web/src/lib/api.ts b/apps/web/src/lib/api.ts
index 2d4731b..2a0a1db 100644
--- a/apps/web/src/lib/api.ts
+++ b/apps/web/src/lib/api.ts
@@ -1,14 +1,12 @@
 /**
  * API client utilities for the web app.
  *
- * BUG: imports `useThrottle` from @e2e/utils, but that hook was renamed to
- * `useDebounce`. This causes a TypeScript error and a runtime crash.
- *
- * Fix: change the import to `useDebounce`.
+ * The debounce hook is imported from @e2e/utils under its current name
+ * (`useDebounce`) and re-exported as `useSearchDebounce` to preserve the
+ * existing public API of this module.
  */
 
-// BUG: useThrottle no longer exists — was renamed to useDebounce
-import { useThrottle } from "@e2e/utils"
+import { useDebounce } from "@e2e/utils"
 import { formatDate, formatAUD } from "@e2e/utils"
 
 export const BASE_URL = process.env.API_URL ?? "http://localhost:3000"
@@ -28,5 +26,5 @@ export async function fetchPosts() {
 // Re-export formatting utilities used throughout the app
 export { formatDate, formatAUD }
 
-// Re-export the debounce hook (currently broken import)
-export { useThrottle as useSearchDebounce }
+// Re-export the debounce hook under its established public name
+export { useDebounce as useSearchDebounce }
diff --git a/bunfig.toml b/bunfig.toml
index 3258d71..1cb73b3 100644
--- a/bunfig.toml
+++ b/bunfig.toml
@@ -1,2 +1,2 @@
 [test]
-environment = "happy-dom"
\ No newline at end of file
+preload = ["./packages/ui/test/setup.ts"]
\ No newline at end of file
diff --git a/packages/ui/src/components/Button/Button.tsx b/packages/ui/src/components/Button/Button.tsx
index af65c97..6efba8b 100644
--- a/packages/ui/src/components/Button/Button.tsx
+++ b/packages/ui/src/components/Button/Button.tsx
@@ -17,14 +17,14 @@ type Props = {
 /**
  * Button component.
  *
- * BUG: When `iconOnly` is true, the button renders without visible text.
- * An `aria-label` is required for screen reader accessibility (WCAG 2.1 SC 4.1.2),
- * but the component does not enforce or warn about its absence.
- *
- * The test in Button.test.tsx checks that an icon-only button has an accessible name.
- * Fix: throw/warn in development when `iconOnly && !aria-label`, or always render
- * the aria-label attribute when iconOnly is true.
+ * An icon-only button has no visible text, so it must expose an accessible
+ * name via `aria-label` (WCAG 2.2 SC 4.1.2 Name, Role, Value). An explicit
+ * `aria-label` is always forwarded to the DOM element. When `iconOnly` is set
+ * without one, we derive a name from string children where possible and
+ * otherwise fall back to a generic label so the control is never unnamed.
  */
+const DEFAULT_ICON_ONLY_LABEL = "Button"
+
 export function Button({
   children,
   icon,
@@ -34,13 +34,24 @@ export function Button({
   onClick,
   "aria-label": ariaLabel,
 }: Props) {
+  const derivedLabel = typeof children === "string" ? children.trim() : ""
+
+  const accessibleLabel =
+    ariaLabel ?? (iconOnly ? derivedLabel || DEFAULT_ICON_ONLY_LABEL : undefined)
+
+  if (process.env.NODE_ENV !== "production" && iconOnly && !ariaLabel) {
+    console.warn(
+      "Button: `iconOnly` buttons should be given an explicit `aria-label` " +
+        `describing their action (WCAG 2.2 SC 4.1.2). Falling back to "${accessibleLabel}".`,
+    )
+  }
+
   return (
     <button
       className={`btn btn-${variant}`}
       disabled={disabled}
       onClick={onClick}
-      // BUG: aria-label is not applied when iconOnly is true and no ariaLabel is passed
-      // The component should enforce aria-label for icon-only buttons
+      aria-label={accessibleLabel}
     >
       {icon && <span className="btn-icon">{icon}</span>}
       {!iconOnly && children}
diff --git a/packages/utils/src/format/date.ts b/packages/utils/src/format/date.ts
index 609e46c..89b1037 100644
--- a/packages/utils/src/format/date.ts
+++ b/packages/utils/src/format/date.ts
@@ -1,26 +1,32 @@
 /**
  * Date formatting utilities.
  *
- * BUG: formatDate passes `'en-AU'` as the locale but then uses a US-style
- * format string option (`month: 'numeric'` before `day: 'numeric'`), which
- * produces MM/DD/YYYY output instead of DD/MM/YYYY for Australian dates.
+ * Produces day-first Australian output with an unpadded day and a 4-digit
+ * year (e.g. 15/6/2024, 1/3/2024).
  *
- * Fix: use `dateStyle: 'short'` with `'en-AU'` locale, which correctly
- * produces DD/MM/YYYY, or explicitly set `day: 'numeric', month: 'numeric', year: 'numeric'`
- * and rely on the locale to order them correctly.
+ * `dateStyle: 'short'` cannot be used because en-AU renders a 2-digit year
+ * ("15/6/24"), and a combined `{ day, month, year }` options object cannot be
+ * used because en-AU zero-pads both the day and month ("01/03/2024"). Each
+ * field is therefore formatted on its own — where en-AU emits it unpadded —
+ * and the parts are reassembled in day/month/year order.
  */
+const dayFormatter = new Intl.DateTimeFormat("en-AU", { day: "numeric" })
+const monthFormatter = new Intl.DateTimeFormat("en-AU", { month: "numeric" })
+const yearFormatter = new Intl.DateTimeFormat("en-AU", { year: "numeric" })
+const timeFormatter = new Intl.DateTimeFormat("en-AU", { timeStyle: "short" })
+
+function part(formatter: Intl.DateTimeFormat, date: Date, type: string): string {
+  const found = formatter.formatToParts(date).find((p) => p.type === type)
+  return found ? found.value : ""
+}
+
 export function formatDate(date: Date): string {
-  // BUG: explicit field order overrides locale ordering — produces M/D/YYYY not D/M/YYYY
-  return new Intl.DateTimeFormat("en-AU", {
-    month: "numeric",
-    day: "numeric",
-    year: "numeric",
-  }).format(date)
+  const day = part(dayFormatter, date, "day")
+  const month = part(monthFormatter, date, "month")
+  const year = part(yearFormatter, date, "year")
+  return `${day}/${month}/${year}`
 }
 
 export function formatDateTime(date: Date): string {
-  return new Intl.DateTimeFormat("en-AU", {
-    dateStyle: "short",
-    timeStyle: "short",
-  }).format(date)
+  return `${formatDate(date)}, ${timeFormatter.format(date)}`
 }
diff --git a/tsconfig.json b/tsconfig.json
index 167f910..eb81c6a 100644
--- a/tsconfig.json
+++ b/tsconfig.json
@@ -6,6 +6,7 @@
     "jsx": "react-jsx",
     "strict": true,
     "skipLibCheck": true,
+    "types": ["bun-types", "react"],
     "paths": {
       "@e2e/ui": ["./packages/ui/src/index.ts"],
       "@e2e/utils": ["./packages/utils/src/index.ts"]