diff --git a/apps/web/src/lib/api.ts b/apps/web/src/lib/api.ts index 2d4731b..56c1c04 100644 --- a/apps/web/src/lib/api.ts +++ b/apps/web/src/lib/api.ts @@ -1,15 +1,8 @@ /** * API client utilities for the web app. - * - * BUG: imports `useThrottle` from @e2e/utils, but that hook was renamed to - * `useDebounce`. This causes a TypeScript error and a runtime crash. - * - * Fix: change the import to `useDebounce`. */ -// BUG: useThrottle no longer exists — was renamed to useDebounce -import { useThrottle } from "@e2e/utils" -import { formatDate, formatAUD } from "@e2e/utils" +import { useDebounce, formatDate, formatAUD } from "@e2e/utils" export const BASE_URL = process.env.API_URL ?? "http://localhost:3000" @@ -28,5 +21,5 @@ export async function fetchPosts() { // Re-export formatting utilities used throughout the app export { formatDate, formatAUD } -// Re-export the debounce hook (currently broken import) -export { useThrottle as useSearchDebounce } +// Re-export the debounce hook under the app-facing name +export { useDebounce as useSearchDebounce } diff --git a/bunfig.toml b/bunfig.toml index 3258d71..0b64f7c 100644 --- a/bunfig.toml +++ b/bunfig.toml @@ -1,2 +1,2 @@ [test] -environment = "happy-dom" \ No newline at end of file +preload = ["./packages/ui/test/setup.ts"] diff --git a/packages/ui/src/components/Button/Button.tsx b/packages/ui/src/components/Button/Button.tsx index af65c97..8b606af 100644 --- a/packages/ui/src/components/Button/Button.tsx +++ b/packages/ui/src/components/Button/Button.tsx @@ -17,13 +17,10 @@ type Props = { /** * Button component. * - * BUG: When `iconOnly` is true, the button renders without visible text. - * An `aria-label` is required for screen reader accessibility (WCAG 2.1 SC 4.1.2), - * but the component does not enforce or warn about its absence. - * - * The test in Button.test.tsx checks that an icon-only button has an accessible name. - * Fix: throw/warn in development when `iconOnly && !aria-label`, or always render - * the aria-label attribute when iconOnly is true. + * When `iconOnly` is true the button renders no visible text, so an `aria-label` + * is required to give it an accessible name (WCAG 2.2 SC 4.1.2). Callers are + * warned in development if they omit it, and a generic fallback is applied so + * the control is never announced as unlabelled. */ export function Button({ children, @@ -34,13 +31,26 @@ export function Button({ onClick, "aria-label": ariaLabel, }: Props) { + // Icon-only buttons have no visible text, so they need an explicit accessible + // name (WCAG 2.2 SC 4.1.2 Name, Role, Value). Warn in development when a + // caller omits it, and fall back to a generic name so the control is never + // announced as an unlabelled "button". + if (iconOnly && !ariaLabel && process.env.NODE_ENV !== "production") { + console.warn( + "[Button] `iconOnly` requires an `aria-label` for screen reader users (WCAG 2.2 SC 4.1.2)." + ) + } + + // Only emit aria-label for icon-only buttons; for text buttons the visible + // label is already the accessible name and must not be overridden. + const resolvedLabel = iconOnly ? ariaLabel ?? "Button" : ariaLabel + return (