No border colors defined for Modern UI

[fweth]

Description

VSCode's new Modern UI draws now borders around floating zones like side panel, editor, chat, etc. In the GitHub theme, these borders are now extremly dim. I suspect that these are not the colors from the theme but some fallback colors because these are new color tokens the theme doesn't support yet:

Here --vscode-editor-border is used (and --vscode-surface-border as fallback) but as far as I can see, they are not supplied by the theme. --vscode-editorGroup-border is supplied by the theme (and has much better contrast) but is overridden by the other variables.

Steps to reproduce

1. Activate Modern UI: "workbench.experimental.modernUI": true
2. Look at the borders drawn around the floating islands, especially in dark mode

Version

v6.3.5

Theme

GitHub Dark Colorblind

[fweth]

Adding the last two lines to index.js fixed it for me locally (editor.border seems to be optional):

"editorGroupHeader.tabsBackground": color.canvas.inset,
"editorGroupHeader.tabsBorder": color.border.default,
"editorGroup.border": color.border.default,

"editor.border": color.border.default,
"surface.border": color.border.default