From ca7cf57780695df495275cb4ac480dfa2ff9cdb0 Mon Sep 17 00:00:00 2001
From: Philipp Kaeser <kaeser@gubbe.ch>
Date: Tue, 25 Aug 2026 21:44:03 +0200
Subject: [PATCH] signal: Improve naming consistency: bs_signal_connect ->
 bs_listener_connect.

---
 include/libbase/signal.h | 16 ++++++++--------
 src/signal.c             | 24 ++++++++++++------------
 2 files changed, 20 insertions(+), 20 deletions(-)

diff --git a/include/libbase/signal.h b/include/libbase/signal.h
index 0be9efc..0f3d44c 100644
--- a/include/libbase/signal.h
+++ b/include/libbase/signal.h
@@ -69,24 +69,24 @@ void bs_signal_emit(
 /**
  * Connects the listener with the provided notification function to the signal.
  *
- * @param signal_ptr
  * @param listener_ptr
  * @param notify
+ * @param signal_ptr
  */
-void bs_signal_connect(
-    struct bs_signal *signal_ptr,
+void bs_listener_connect(
     struct bs_listener *listener_ptr,
-    bs_signal_notify_t notify);
+    bs_signal_notify_t notify,
+    struct bs_signal *signal_ptr);
 
 /**
  * Disconnects the listener from the signal.
  *
- * @param signal_ptr
  * @param listener_ptr
+ * @param signal_ptr
  */
-void bs_signal_disconnect(
-    struct bs_signal *signal_ptr,
-    struct bs_listener *listener_ptr);
+void bs_listener_disconnect(
+    struct bs_listener *listener_ptr,
+    struct bs_signal *signal_ptr);
 
 /** A listener that can be used in unit tests. */
 struct bs_test_listener {
diff --git a/src/signal.c b/src/signal.c
index 82f90cc..c4e8128 100644
--- a/src/signal.c
+++ b/src/signal.c
@@ -47,10 +47,10 @@ void bs_signal_emit(
 }
 
 /* ------------------------------------------------------------------------- */
-void bs_signal_connect(
-    struct bs_signal *signal_ptr,
+void bs_listener_connect(
     struct bs_listener *listener_ptr,
-    bs_signal_notify_t notify)
+    bs_signal_notify_t notify,
+    struct bs_signal *signal_ptr)
 {
     listener_ptr->notify = notify;
     bs_dllist_push_back(
@@ -59,9 +59,9 @@ void bs_signal_connect(
 }
 
 /* ------------------------------------------------------------------------- */
-void bs_signal_disconnect(
-    struct bs_signal *signal_ptr,
-    struct bs_listener *listener_ptr)
+void bs_listener_disconnect(
+    struct bs_listener *listener_ptr,
+    struct bs_signal *signal_ptr)
 {
     bs_dllist_remove(
         &signal_ptr->listeners,
@@ -81,10 +81,10 @@ void bs_test_listener_connect(
     struct bs_signal *signal_ptr,
     struct bs_test_listener *test_listener_ptr)
 {
-    bs_signal_connect(
-        signal_ptr,
+    bs_listener_connect(
         &test_listener_ptr->listener,
-        _bs_test_listener_notify);
+        _bs_test_listener_notify,
+        signal_ptr);
 }
 
 /* ------------------------------------------------------------------------- */
@@ -92,9 +92,9 @@ void bs_test_listener_disconnect(
     struct bs_signal *signal_ptr,
     struct bs_test_listener *test_listener_ptr)
 {
-    bs_signal_disconnect(
-        signal_ptr,
-        &test_listener_ptr->listener);
+    bs_listener_disconnect(
+        &test_listener_ptr->listener,
+        signal_ptr);
 }
 
 /* == Local (static) methods =============================================== */