Skip to content

feat: add tenant domain model and update static YAML catalog - #672

Open
RawanMatar89 wants to merge 4 commits into
openedx:developfrom
zeit-labs:infra/01-tenant-model
Open

feat: add tenant domain model and update static YAML catalog#672
RawanMatar89 wants to merge 4 commits into
openedx:developfrom
zeit-labs:infra/01-tenant-model

Conversation

@RawanMatar89

Copy link
Copy Markdown
Contributor

Summary

Adds the Tenant domain model and TenantsConfig container that later multi-tenant PRs build on. Inert — nothing in the app calls it yet.

Included

  • Tenant / TenantsConfig (Core): per-tenant API/SSO/OAuth fields, UI feature-flag overrides, raw branding fields (color, logoURLString, themeColors) for a later theming PR to render
  • UIComponentsConfig@unchecked Sendable (required so Tenant can hold one as a stored property)
  • config.yaml TENANTS: block — one placeholder tenant, not real data

Not included

  • Remote catalog fetch, TenantStore selection/session state, anything reading TenantProvider — separate PRs
  • JSON parsing path in TenantsConfig.swift (stops at its own // MARK: Remote (JSON) parsing boundary)

Testing

Built and ran successfully on device.


Note

This is the first pull-request of the multi-tenant infrastructure extraction.

@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @RawanMatar89!

This repository is currently maintained by @openedx/openedx-mobile-maintainers.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Sep 1, 2026
@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Sep 1, 2026
Adds the Sendable Tenant value type and TenantsConfig container that
later multi-tenant layers build on: per-tenant API/SSO/OAuth config,
UI feature flags (UIComponentsConfig, now @unchecked Sendable), and
raw branding fields for a later theming layer to render.

Tenant(dictionary:) parses config.yaml's new TENANTS block.

Not included here: remote catalog fetching, tenant selection/session
state, and anything reading TenantProvider — those land as separate
PRs. TENANTS data in config.yaml is illustrative, not real tenants.
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Ready for Review

Development

Successfully merging this pull request may close these issues.

4 participants