From d6a7e179b19024bbc5d5cd6083b85d517a6557d2 Mon Sep 17 00:00:00 2001 From: "Adolfo R. Brandes" Date: Sat, 29 Aug 2026 10:00:31 -0300 Subject: [PATCH] fix: fail npm run lint when eslint reports errors The lint script chained its commands with semicolons, so it exited with the status of the last one and CI stayed green with lint errors present. Fixes #295 Co-Authored-By: Claude --- package.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index bb353fdf..1f532b4e 100644 --- a/package.json +++ b/package.json @@ -30,8 +30,8 @@ "clean": "make clean", "dev": "npm run build && node ./dist/tools/cli/openedx.js dev:shell", "docs": "jsdoc -c jsdoc.json", - "lint": "eslint .; npm run lint:tools; npm --prefix ./test-site run lint", - "lint:fix": "eslint . --fix; npm run lint:fix:tools", + "lint": "eslint . && npm run lint:tools && npm --prefix ./test-site run lint", + "lint:fix": "eslint . --fix && npm run lint:fix:tools", "lint:tools": "cd ./tools && eslint . && cd ..", "lint:fix:tools": "cd ./tools && eslint . --fix && cd ..", "pack": "mkdir -p pack && npm pack --silent --pack-destination pack >/dev/null && mv \"$(ls -t pack/*.tgz | head -n 1)\" pack/openedx-frontend-base.tgz",