Share to conversation: note is not remembered

[tobiasKaminsky]

• share a file to a conversation
• set expiration date
• set note
• reload
• see that expiration date is set, but note is forgotten

Is it useful to have a note for this kind of share?
So, either

• remove note option
• make it working and show it somehow(?) in Talk, as currently there those shared files are "only" inline and I do not know what the best way is to show a note there

@jancborchardt

[tobiasKaminsky]

@AndyScherzinger can you discuss this in next planing meeting?

[AndyScherzinger]

@tobiasKaminsky so from you're description this is a server+talk effort then which needs design feedback first, right? If so I can pick this up with the folks while we don't yet plan (random) bugs to be fixed. So there is no ETA on this.

[tobiasKaminsky]

First the question "if a note is useful at all when sharing a file to conversation?" needs to be answered, that is why I pinged you, as we (devs) should not decide this without any approval from Frank/Jan/you, right?
If this is then decided, action depends on the answer, see then bullet points.

So for now I just pinged you to get an answer. When/what is then done later, can be planned at some point, if time permits.
(our new process is still a bit unclear in some cases…)

[AndyScherzinger]

Taking any potential blame, I'd say @jancborchardt can give us a product-managemtn-wise decision since this seems to be small-ish and we should be able to get this forward without needing to involve Frank. What do you think @jancborchardt ?

[jancborchardt]

Thought a bit about it since we talked last @tobiasKaminsky and I’d say for consistency it’s probably best to make it work in all scenarios.

In Talk for example, the viewer does also have the ability to "Open sidebar" (and should have it I’d argue, so things can be shared further), and the note could be shown in the sidebar. (Note though that the sidebar seems to be bugged in Talk currently, at least I can not make it appear.)

[szaimen]

Hi, please update to 24.0.9 or better 25.0.3 and report back if it fixes the issue. Thank you!

My goal is to add a label like e.g. 25-feedback to this ticket of an up-to-date major Nextcloud version where the bug could be reproduced. However this is not going to work without your help. So thanks for all your effort!

If you don't manage to reproduce the issue in time and the issue gets closed but you can reproduce the issue afterwards, feel free to create a new bug report with up-to-date information by following this link: https://github.com/nextcloud/server/issues/new?assignees=&labels=bug%2C0.+Needs+triage&template=BUG_REPORT.yml&title=%5BBug%5D%3A+

[tobiasKaminsky]

Still happens on latest master.