Request etag

[marinofaggiana]

The request for ocs/v2.php/apps/recommendations/api/v1/recommendations doesn't return the etags. On the client side, we never know if the preview has changed, so we're forced to request file information (PROPFIND) to determine if anything has changed.

We're asking for the etag field to be added to the response items.

[marinofaggiana]

cc @alperozturk96

[ChristophWurst]

The feature request makes sense

[ChristophWurst]

The current limitation is that the three data sources do not provide an etag.

For comparison: in nextcloud files the etag is changed when anyone modifies a node. so comparing an older etag to the current one is a very efficient way to find out if anything changed.

In Recommendations, hover, the file sources do not give us an etag currently. so I can't forward the information cheaply. I have to build the full dataset, hash it, and pass this as etag. so if you, as a client, request the etag, you create the same load as just requesting the data. if you find out that the etag changed and then request the data you will cause twice the load for the server.

So, unfortunately, as a prerequisite we have to first build etags into recently edited files API of files, recently shared of sharing and recently commented of comments. When we have these, we can combine the tree etags into one that is returned for recommended files.

[alperozturk96]

@tobiasKaminsky Until this feature request is implemented, we could leverage the existing ignoreETag boolean in the client code. This would allow us to update the recommended files only when a full refresh of the entire list is required, what do you think?

[tobiasKaminsky]

@ChristophWurst thanks for clarification.

Then we have to wait 👍

[ChristophWurst]

PR for per file etag at #905

[ChristophWurst]

I possibly misunderstood the original request. @alperozturk96 @tobiasKaminsky do you need an etag for the collection/list of recommended files to find out if there are new recommendations, or an etag per recommended file to know if the file itself has changed?

[ChristophWurst]

@alperozturk96 @tobiasKaminsky do you need an etag for the collection/list of recommended files or an etag per recommended file?

[tobiasKaminsky]

One etag to the endpoint, to compare if we actually need to fetch list of recommended files, or can display the old one.
Similar like with capabalities. There we send If-None-Match with etag.
And server returs 304 if not modified, or sends actual new content.

[ChristophWurst]

Thanks! In that case we have to wait for etag support on the sources, as described in #895 (comment)