Skip to content

Return value of CFE_MSG_GetMsgId is not checked during ProcessCommandPacket or VerifyCmdLength #159

Description

@asgibson

Describe the bug
CFE_MSG_GetMsgId returns a status value to indicate success or failure of the call, but neither of the usages in the sample app check if it is successful nor do they state that the return value is ignored by design.

To Reproduce
N/A

Expected behavior
Sample app should either make use of the return value to verify success or should note the reason why this is not being done.

Code snips

CFE_MSG_GetMsgId(&SBBufPtr->Msg, &MsgId);

CFE_MSG_GetMsgId(MsgPtr, &MsgId);

System observed on:
N/A

Reporter Info
Alan Gibson NASA/GSFC 587

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions