On a Dependabot PR in mozilla/fxa (postcss), the fix-dependabot-pr workflow committed a change to a non-dependency source file to make BLEnder's own CI pass:
It rewrote _scripts/check-node-version.sh, loosening fxa's intentional exact-Node guard to a ^ range. Problems:
- Scope creep. A dependency bump shouldn't edit unrelated repo source — only manifests/lockfiles.
- Overrides repo policy. fxa deliberately enforces an exact Node version. The right fix for BLEnder's runner using the wrong Node is the
node_version config pin (which exists), not weakening the repo's guard.
- Drags in code-owner review. The edited script is code-owned, so the otherwise CODEOWNERS-exempt dep PR became
REVIEW_REQUIRED / blocked.
- Strips the executable bit. The commit (via GitHub contents API) changed
100755 → 100644; a maintainer had to restore it by hand (mozilla/fxa@6567934).
- It acted on a dependency BLEnder itself had judged not affected.
Suggestion: constrain the fix workflow to dependency/lock files (package manifests + lockfiles) and refuse edits outside them, and preserve file mode on commits.
On a Dependabot PR in mozilla/fxa (postcss), the
fix-dependabot-prworkflow committed a change to a non-dependency source file to make BLEnder's own CI pass:It rewrote
_scripts/check-node-version.sh, loosening fxa's intentional exact-Node guard to a^range. Problems:node_versionconfig pin (which exists), not weakening the repo's guard.REVIEW_REQUIRED/ blocked.100755 → 100644; a maintainer had to restore it by hand (mozilla/fxa@6567934).Suggestion: constrain the fix workflow to dependency/lock files (package manifests + lockfiles) and refuse edits outside them, and preserve file mode on commits.