From 5898384f853b8fbc50765fbb01b271922a3603a9 Mon Sep 17 00:00:00 2001 From: Curtis Anderson Date: Tue, 11 Aug 2026 14:24:11 -0700 Subject: [PATCH 1/2] =?UTF-8?q?test(cli):=20RED=20=E2=80=94=20--help=5Fall?= =?UTF-8?q?=20must=20document=20--checkpoint-subset?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The curated reference in help_formatter.py is hand-maintained, not generated from argparse; 828cc63 added the flag to the parser only, so --help_all silently omits it. --- tests/unit/test_help_behavior.py | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/tests/unit/test_help_behavior.py b/tests/unit/test_help_behavior.py index 557d6f86..0498dc43 100644 --- a/tests/unit/test_help_behavior.py +++ b/tests/unit/test_help_behavior.py @@ -49,6 +49,17 @@ def test_help_all_prints_synopsis(self, capsys): out = capsys.readouterr().out assert 'SYNOPSIS' in out + def test_help_all_documents_checkpoint_subset(self, capsys): + """--checkpoint-subset (added with the parser in 828cc63, storage#841) + must appear in the curated reference — the page is hand-maintained, + not generated from argparse, so a parser-only change silently omits + the flag here.""" + with patch('sys.argv', ['mlpstorage', '--help_all']): + with pytest.raises(SystemExit): + parse_arguments() + out = capsys.readouterr().out + assert '--checkpoint-subset' in out + def test_help_all_prints_kv_section(self, capsys): with patch('sys.argv', ['mlpstorage', '--help_all']): with pytest.raises(SystemExit): From f950b9191b6da9b34e5595cd913b06cb581430d9 Mon Sep 17 00:00:00 2001 From: Curtis Anderson Date: Tue, 11 Aug 2026 14:24:28 -0700 Subject: [PATCH 2/2] =?UTF-8?q?fix(cli):=20GREEN=20=E2=80=94=20document=20?= =?UTF-8?q?--checkpoint-subset=20in=20the=20--help=5Fall=20reference?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Added to CK_RUN_CLOSED's Optional block (CK_RUN_OPEN/WHATIF inherit via '= CK_RUN_CLOSED plus:'), annotated '8B at 8 processes only; declares a Subset run' consistent with Rules.md 4.3.5 and check_subset_mode. --- mlpstorage_py/cli/help_formatter.py | 1 + 1 file changed, 1 insertion(+) diff --git a/mlpstorage_py/cli/help_formatter.py b/mlpstorage_py/cli/help_formatter.py index 6f09fc40..9d5375b5 100644 --- a/mlpstorage_py/cli/help_formatter.py +++ b/mlpstorage_py/cli/help_formatter.py @@ -292,6 +292,7 @@ --results-dir/-rd PATH [storage positional: file | object] Optional: + --checkpoint-subset (8B at 8 processes only; declares a Subset run) --exec-type/-et {mpi,docker} (default: mpi) --hosts/-s HOST... (default: 127.0.0.1) --num-checkpoints-read/-ncr N (default: 10; closed allows 10 or 0)