MacRoman sending encoding is not correct

[Knezzen]

Hi!

Thanks for an awesome Hotline client. It's what I use every day and It's wonderful to say the least!

It seems like Hotline doesn't convert to MacRoman properly. Posting scandinavian letters (åäö) in Hotline gives junk output in the chat log in "Classic" clients. Posting scandinavian letters from "Classic" clients gives the correct output in Hotline, so it seems like the convert before sending chat in Hotline is to blame for the bug.

[mierau]

Thanks! I clearly need to revisit my dumb code that attempts to handle this. I tried to get clever thinking I could detect different encodings and adapt but I think letting a person choose per server probably makes more sense. 🙂

[mlrk3y]

All good bud - I’m not so big programming expert or I’d offer to help… I just saw your very cool project on the front page of HN and wanted to try to stay updated 😃 Appreciate all you do :)

[rbdr]

Hey y'all, I have a commit in my fork that I believe addresses this issue: https://git.sr.ht/~rbdr/hotline/commit/a1ab15155846932af41907c4c3a66ef489a29c2c

[rbdr]

I realize this only takes care of the sending, but it might still display Mac OS Roman incorrectly when received.

This commit here is a bit more harsh since it gets rid of a lot of the encoding logic and just assumes everything coming in is Mac OS Roman. https://git.sr.ht/~rbdr/hotline/commit/332022b4f4ec63b0625b70ec61c902b689579af2

I don't think the spec defines this (other than for the tracker), but I imagine classic clients would send mac roman or one of the mac encodings. But I think then storing it in the server wouldn't be too hard.