GameInput 3.5.262 giving information from USB hubs that GIP devices are connected to, instead of information about the devices themselves

[sanjay900]

I updated to the latest gameinput to test things, and realised that none of my instrument code was working anymore. After debugging, i realised that GameInput is now giving me information from my usb hub instead of my GIP device. This means that any matching being done in VID/PID or name

GameInput 3.5.262:

GameInput 3.4.265:

[sanjay900]

@lsalvadormsft / @AlexYatskov is this something we can get fixed quickly? Im worried that once some game somewhere starts installing the latest release, a bunch of rhythm games will stop being able to detect these devices properly because they are matching guitars and drum kits based on vid and pid

[lsalvadormsft]

@sanjay900 we have tried the code with the PDP Riffmaster guitar and we see the VID/PID accurately enumerating across both versions. May we ask you if you are seeing the same thing on that device? Also, what device are you currently testing against? There are device name differences between the two versions, but we are still seeing the same VID/PID.

[sanjay900]

Tested with a crkd guitar and a santroller drum kit + guitar
If it helps I'm using a windows 11 VM for testing purposes, does anything happen differently if you have a USB hub in the mix?

I don't own a riffmaster myself so I can't test with that.

If you have a raspberry pi pico on hand I can give you a firmware that emulates a device I'm doing my testing with

[sanjay900]

Have there been any changes to enumeration at all with that latest release?

[sanjay900]

If it helps I've just been using SDL to test

[sanjay900]

Well, i just went to try and replicate the issue this morning and now its not happening, so im not sure what was going on there

What i am noticing is that now is that we get the vid and pid from the usb device now, instead of the one from the announce packet which was the previous behaviour, and while that normally should be the same, in some scenarios it isn't

[sanjay900]

After some further testing, it seems this is only happening with one of my devices, and im not really sure why that is

[sanjay900]

@lsalvadormsft
I assume when you guys added some changes to fix issues with the device name being missing sometimes, you started grabbing information from the usb device to grab its name, but then also started fetching the VID and PID from it instead of using the VID and PID that was being used previously, and i assume for whatever reason this logic is breaking on this guitar im testing with and its not finding the correct usb device to pull the attributes from, and somehow its ending up with the attributes from the usb hub its connected to.

And then with my other guitar and drum kit, i was intentionally using a different vid and pid in the announce packet so other software that wasn't using GIP could identify it, but this change means i can no longer detect these devices correctly

[lsalvadormsft]

@sanjay900 can you send us a screenshot of what the guitar's container (group by container) looks like in Device Manager for you? That would help us understand what the diff looks like for this device compared to others. There might be a broken assumption that does not match how this particular device enumerates in the host. Thanks!

[sanjay900]

[sanjay900]

Interesting, yeah the Input.Gaming category is missing

[sanjay900]

[sanjay900]

@lsalvadormsft
What actually controls that category field? Fixing things on the gameinput side is good but if theres also something we should be doing in the firmware that affects this i can get that looked into as well.