Skip to content

Ignoring results for checking broken web links are hiding actual broken internal links #1251

Description

Page url

https://microsoft.github.io/react-native-windows/v1/docs/debugging-javascript

Problem Description

The CI was updated in #1150 to allow it to pass if time-outs occur when checking for links. Which is fine, except there are local only links within the website that are also failing, and are also being ignored.

For example, see the link provided, with a broken image:

Image

I'd recommend two separate checks in the website building:

  1. One that calls unbroken with --local-only to catch broken internal links (between docs pages) and has no time-out
  2. The current call to unbroken that also checks external links, and has the timeout

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions