Log improvements

[Stas (stishkin)]

Moving out data-values from log messages into CustomDimensions

Code to produce AppInsights entry:

[Stas (stishkin)]

Change tags in the message from Tag:ToState to {ToState} ?

[Marc Greisen (mgreisen)]

Sounds good to me.

[Teo Voinea (tevoinea)]

It would also be nice if we could enforce some sort of naming consistency for these tags to make it easier to query/join across different message types. Could it be sufficient to say the tag name has to be the property name? Our models are pretty consistent.

The downside with coupling tag name to model property name is that we might want to do a custom tag name in the telemetry for whatever reason so we would need a way to override the default behavior.

[Stas (stishkin)]

+1 for consistency

We have cases where tags are used but those values are not part of the models.
In the snippet that I provided we use State two times in the log message.

For now - it's manual consistency. If we think of a method to enforce it - we'll implement that.

As we cleanup logs - there might be typos discovered in the log, but those are easy to fix.

[Stas (stishkin)]

#2450