feat: add animated ship targets to landing hero, clean up plans - #126
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ca18502 to
7c486db
Compare
|
@codex review |
7c486db to
c6c88c2
Compare
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
c6c88c2 to
97036aa
Compare
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 97036aa060
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| )) | ||
| } | ||
| <span | ||
| class="ship-target-phrase absolute top-0 left-1/2 inline-flex whitespace-nowrap [transform:translateX(calc(-50%+var(--ship-target-shift,0px)))] transition-transform duration-[320ms] ease-[cubic-bezier(0.45,0,0.55,1)] will-change-transform motion-reduce:transform-none motion-reduce:transition-none" |
There was a problem hiding this comment.
When prefers-reduced-motion: reduce is enabled, motion-reduce:transform-none removes the translateX(-50%) that centers this absolutely positioned phrase while left-1/2 remains active. Because the stage also has overflow-hidden, the phrase begins halfway across the available width and its trailing text is clipped; disable the transition for reduced motion without removing the centering transform.
AGENTS.md reference: AGENTS.md:L64-L65
Useful? React with 👍 / 👎.
97036aa to
dbd705f
Compare
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dbd705f5bd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| --- | ||
|
|
||
| <p>{m.example_message({ username: "Init" }, { locale })}</p> | ||
| <p>{m.docs_example_greeting({ username: "Init" })}</p> |
There was a problem hiding this comment.
When English and Spanish documentation pages are rendered concurrently, this locale-less message call reads from the globalVariable strategy configured in apps/docs/astro.config.ts, while middleware mutates that shared locale before calling next(). Another render can therefore overwrite the locale before this component executes, producing an English greeting on the Spanish page or vice versa; preserve the previous explicit Astro.currentLocale message option or use request-scoped locale state.
Useful? React with 👍 / 👎.
1 participant
Refresh the
init.nowlanding page hero with a rotating "Ship for…" target phrase animation and clean up the command bar styling. The.plans/directory is removed now that all tracked plans are complete.Landing page
ShipTargetscomponent that cycles through the six supported targets (web apps, mobile apps, desktop apps, marketing sites, documentation sites, browser extensions) with a smooth exit/enter animation driven byship-targets-animation.ts. The animation pauses when the element leaves the viewport or the document is hidden, and is fully disabled underprefers-reduced-motion.34remto26remand converts the copy button from a text+icon layout to a square icon-only button, removing the visible "Copy" label and its associated DOM manipulation.$prompt color from sky blue to neutral to reduce visual noise.650to800.landing_ship_*i18n keys to both locale files, including a screen-reader-only summary sentence for the animated region.Plans cleanup
Removes the entire
.plans/directory. All plans (01–15) are marked completed in the tracker, so the planning documents are no longer needed in the working tree.