The stream loses data

[DmitryMyadzelets]

In this use case we send a file. All data are lost if the file is small, or received partially if the file is big.

How to reproduce:

const fs = require('fs')
const reader = fs.ReadStream('index.js')
const writer = fs.WriteStream('out')
const socket = require('websocket-stream')('ws://echo.websocket.org')

reader.pipe(socket).pipe(writer)

// Now compare the size of the input and output files

Node.js v8.6.0

[DmitryMyadzelets]

Have found that the stream intentionally throws away any data unless the socket is connected. What is a rationale behind such decision?

[mcollina]

This module is very old, and there might not be a good rationale behind some of the code. If you want to help maintaining this you are welcome to propose a change.

[DmitryMyadzelets]

With modern Node.js making a stream over a WebSocket (ws module) seems quite simple for a trivial use case.

May a complete refactoring be considered?

[mcollina]

As long as the API stays similar and the tests passes, I see no problem.