JSON complain Cpanel::JSON indent_length not supported by Cpanel::JSON::XS

[yairlenga]

The JSON module produce incorrect warning about Cpanel::JSON::XS not supporting indent_length. Recent versions of Cpanel supported this method, and the code dispatch the call to the Cpanel backend.

Error Message:

indent_length is not supported by Cpanel::JSON::XS. at ...

Minimal Code to replicate:

export PERL_JSON_BACKEND=Cpanel::JSON::XS
perl -e 'use JSON ; my $json = new JSON ; $json->indent_length(2)'

Output:

indent_length is not supported by Cpanel::JSON::XS. at -e line 1.

Suggessted Solution:

Code currently has hard-coded list of methods that are only available with JSON::PP

my @PPOnlyMethods = qw/
    indent_length sort_by
    allow_singlequote allow_bignum loose allow_barekey escape_slash as_nonblessed

Suggesting use can(...) to check for on the selected backend if the method will be suppored. At this point, Cpanel support indent_length and (limited) sort_by, allow_bignum and more.

[yairlenga]

The following test program tests indent_length on JSON, JSON::PP, JSON::XS and Cpanel::JSON::XS. It shows that Cpanel::JSON::XS can support this method, and only JSON::XS need the protection.

Tested with perl 5.38 on Ubuntu 24.04 LTS, under WSL2

Test Program for all JSON modules:

BEGIN {
        $ENV{PERL_JSON_BACKEND} = 'Cpanel::JSON::XS' ;
}

use strict ;

sub test_indent_length {
        my $class = shift ;
        warn "=== Testing: $class\n" ;
        my $v = eval {
                eval "require $class" ;
                my $json = new $class ;
                $json->indent_length(2) ;
                $json->get_indent_length ;
        } ;
        warn "   indent_length=$v\n   Error=$@\n" ;
}

test_indent_length('JSON') ;
test_indent_length('JSON::XS') ;
test_indent_length('JSON::PP') ;
test_indent_length('Cpanel::JSON::XS') ;
1 ;

Current Output:

=== Testing: JSON
indent_length is not supported by Cpanel::JSON::XS. at x.pl line 13.
   indent_length=3
   Error=
=== Testing: JSON::XS
   indent_length=
   Error=Can't locate object method "indent_length" via package "JSON::XS" at x.pl line 13.

=== Testing: JSON::PP
   indent_length=2
   Error=
=== Testing: Cpanel::JSON::XS
   indent_length=2
   Error=

[karenetheridge]

indent_length was added to Cpanel::JSON::XS in version 4.02.