Summary
GitHubApiBaseUri and GitHubApiVersion are currently populated with their standard values in tests/maester-config.json, even though Connect-MtGitHub already provides and validates the same defaults in code.
The baseline configuration should contain user or tenant overrides, not duplicate product defaults.
Proposed change
- Remove
GitHubApiBaseUri and GitHubApiVersion from the shipped tests/maester-config.json.
- Keep the existing resolution order in
Connect-MtGitHub:
- Explicit cmdlet parameter
- Custom
maester-config.json setting
- Code default
- Retain the current validated code defaults:
https://api.github.com2022-11-28
- Preserve support for GHE.com and explicit API-version overrides.
- Add or adjust tests to prove the code defaults are used when the settings are absent.
- Document these as optional override settings.
Rationale
This keeps the shipped configuration focused on actual configuration data and avoids presenting built-in defaults as if users need to manage them. It also provides one authoritative location for defaults while preserving all existing override behavior.
Summary
GitHubApiBaseUriandGitHubApiVersionare currently populated with their standard values intests/maester-config.json, even thoughConnect-MtGitHubalready provides and validates the same defaults in code.The baseline configuration should contain user or tenant overrides, not duplicate product defaults.
Proposed change
GitHubApiBaseUriandGitHubApiVersionfrom the shippedtests/maester-config.json.Connect-MtGitHub:maester-config.jsonsettinghttps://api.github.com2022-11-28Rationale
This keeps the shipped configuration focused on actual configuration data and avoids presenting built-in defaults as if users need to manage them. It also provides one authoritative location for defaults while preserving all existing override behavior.