Skip to content

Follow-ups to #792 #936

Description

@tnull
  • Codex review:
  • [P1] trust_peer_0conf is only honored for LSPS2-discovered LSPs: /home/tnull/worktrees/ldk-node/pr-792/src/event.rs:1323. add_liquidity_source(..., true) documents generic 0-conf trust for the LSP (/home/tnull/worktrees/ldk-node/pr-792/src/builder.rs:448, /home/tnull/worktrees/ldk-node/pr-
    792/src/liquidity/mod.rs:117), but inbound acceptance only looks up protocol 2. LSPS1-only LSPs, or trusted LSPs before/after failed LSPS0 discovery, now fall through to accept_inbound_channel instead of accept_inbound_channel_from_trusted_peer. The trust lookup should be by node id
    independent of protocol; keep the LSPS2 protocol check only for accept_underpaying_htlcs.
  • Codex nit:
  • [P3] Three new files have CRLF line endings, so git diff --check upstream/main...HEAD reports trailing whitespace on every line: /home/tnull/worktrees/ldk-node/pr-792/src/liquidity/client/mod.rs:1, /home/tnull/worktrees/ldk-node/pr-792/src/liquidity/service/mod.rs:1, /home/tnull/worktrees/
    ldk-node/pr-792/src/liquidity/service/lsps2.rs:1. cargo fmt tolerates it, but diff whitespace checks will fail. Normalize those files to LF.
  • The PR made LSP functionalities always enabled (dropped the Ignoring CMH default). We might want to revisit that decision in conjuction with Introduce Rust features #900, as we might want to add features to enable LSP {client,service} functionalities. It might prove to be hard to do this from an API-design perspective, we'll see.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions