From 472278d1f327a1b0e2bf670d9dce42eee2ada25c Mon Sep 17 00:00:00 2001 From: jsonbailey Date: Thu, 16 Jul 2026 16:54:42 -0500 Subject: [PATCH 1/2] chore: Remove dead __BUILTINS__ constant --- ldclient/__init__.py | 2 -- ldclient/impl/evaluator_common.py | 2 -- ldclient/impl/util.py | 2 -- 3 files changed, 6 deletions(-) diff --git a/ldclient/__init__.py b/ldclient/__init__.py index b1341f95..1536f331 100644 --- a/ldclient/__init__.py +++ b/ldclient/__init__.py @@ -14,8 +14,6 @@ __LONG_SCALE__ = float(0xFFFFFFFFFFFFFFF) -__BUILTINS__ = ["key", "ip", "country", "email", "firstName", "lastName", "avatar", "name", "anonymous"] - """Settings.""" start_wait = 5 diff --git a/ldclient/impl/evaluator_common.py b/ldclient/impl/evaluator_common.py index 5e7c93f0..52a03977 100644 --- a/ldclient/impl/evaluator_common.py +++ b/ldclient/impl/evaluator_common.py @@ -19,8 +19,6 @@ __LONG_SCALE__ = float(0xFFFFFFFFFFFFFFF) -__BUILTINS__ = ["key", "secondary", "ip", "country", "email", "firstName", "lastName", "avatar", "name", "anonymous"] - # EvalResult is used internally to hold the EvaluationDetail result of an evaluation along with # other side effects that are not exposed to the application, such as events generated by diff --git a/ldclient/impl/util.py b/ldclient/impl/util.py index 54caf9de..111fe8da 100644 --- a/ldclient/impl/util.py +++ b/ldclient/impl/util.py @@ -23,8 +23,6 @@ def timedelta_millis(delta: timedelta) -> float: __LONG_SCALE__ = float(0xFFFFFFFFFFFFFFF) -__BUILTINS__ = ["key", "ip", "country", "email", "firstName", "lastName", "avatar", "name", "anonymous"] - __BASE_TYPES__ = (str, float, int, bool) # Maximum length for SDK keys From 461e621e11eeab5cd456d5125d3972d0bf8d5b25 Mon Sep 17 00:00:00 2001 From: jsonbailey Date: Fri, 17 Jul 2026 10:45:25 -0500 Subject: [PATCH 2/2] docs: Reference SDK-2696 on the ldclient.util logger comment --- ldclient/impl/util.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ldclient/impl/util.py b/ldclient/impl/util.py index 111fe8da..fda0e4fd 100644 --- a/ldclient/impl/util.py +++ b/ldclient/impl/util.py @@ -18,7 +18,8 @@ def timedelta_millis(delta: timedelta) -> float: return delta / timedelta(milliseconds=1) -log = logging.getLogger('ldclient.util') # historical logger name +# historical logger name; cleaning up the SDK's logger names is tracked in SDK-2696 +log = logging.getLogger('ldclient.util') __LONG_SCALE__ = float(0xFFFFFFFFFFFFFFF)