Skip to content
This repository was archived by the owner on Aug 13, 2022. It is now read-only.
This repository was archived by the owner on Aug 13, 2022. It is now read-only.

Missing physical currency #27

Description

@victor-david

The Costa Rican Colón (CRC) is not included in the AlphaVantage.Net.Common.Currencies.PhysicalCurrency enumeration.

I've verified that this currency is supported by Alpha Vantage by making a raw request:

using (AlphaVantageClient client = new("key"))
{
    Dictionary<string, string> query = new()
    {
        { ApiQueryConstants.FromSymbolQueryVar, "USD" },
        { ApiQueryConstants.ToSymbolQueryVar, "CRC" },
        { ApiQueryConstants.OutputSizeQueryVar, "compact" }
    };

    string stringResult = await client.RequestPureJsonAsync(ApiFunction.FX_DAILY, query);
}

I downloaded the physical currency Excel from AV. CRC is not included there, so I can see why it didn't wind up in the code.

Anyway, a heads up in case this project is still active. Thanks.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions