fix(timeline): remove the dead Add Full Camera toolbar button (cherry-pick for 1.10.0-rc.2) - #472
Conversation
The button always looked clickable but silently no-opped on any project without a webcam clip. Add Full Camera stays reachable via the C shortcut and the AI agent tool, both of which already gate on hasAnyClipWithCamera (#353) and are unaffected by this change.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Fermeture : le bouton visé n'était pas celui-ci ("Add Full Camera") mais un autre bouton "fullscreen" — je reverte #466 sur main en parallèle. |
|
Ré-ouverture : #466 était bien le bon fix, la confusion portait juste sur le nom du bouton. Ce cherry-pick vers release/v1.10.0 redevient valide. |
Summary
Cherry-pick of #466 onto
release/v1.10.0for the next RC.Maximize2,V4Timeline.tsx) — it always looked clickable but silently no-ops (addCameraFullscreenrefuses to write a region) on any project without a webcam clip, per the [Bug]: Add Full Camera is offered on projects with no webcam and silently renders nothing #353 gate.Cshortcut and the AI agent tool both call the same gatedaddCameraFullscreenstore action, and the timeline lane still renders/edits existing camera-fullscreen regions.buttons.addCameraFullscreenstring from all 13 locales.Related issue
No tracked issue — reported directly by screenshot, confirmed non-functional by reading the code path. See #466 for the original review discussion.
Type of change
Release impact
Desktop impact
Screenshots / video
Not attached — this removes one existing toolbar icon (
Maximize2, "Add Full Camera") with no other visual change.Testing
Cherry-picked commit is identical in content to the one already merged and verified on
main(#466). Re-ran on top ofrelease/v1.10.0(currently1.10.0-rc.1):npx vitest runover the affected suites — 71 tests passnpx biome checkon all changed files — cleannpx tsc --noEmit— cleannpm run i18n:check— all 12 locales still matchenCherry-picked cleanly with no conflicts (
git cherry-pick, same 16-file diff).🤖 Generated with Claude Code