Skip to content

fix(timeline): remove the dead Add Full Camera toolbar button (cherry-pick for 1.10.0-rc.2) - #472

Closed
EtienneLescot wants to merge 1 commit into
release/v1.10.0from
claude/remove-nonfunctional-button-rc2-cherrypick
Closed

fix(timeline): remove the dead Add Full Camera toolbar button (cherry-pick for 1.10.0-rc.2)#472
EtienneLescot wants to merge 1 commit into
release/v1.10.0from
claude/remove-nonfunctional-button-rc2-cherrypick

Conversation

@EtienneLescot

@EtienneLescot EtienneLescot commented Aug 22, 2026

Copy link
Copy Markdown
Collaborator

Summary

Cherry-pick of #466 onto release/v1.10.0 for the next RC.

  • Remove the "Add Full Camera" icon button from the timeline toolbar (Maximize2, V4Timeline.tsx) — it always looked clickable but silently no-ops (addCameraFullscreen refuses to write a region) on any project without a webcam clip, per the [Bug]: Add Full Camera is offered on projects with no webcam and silently renders nothing #353 gate.
  • Add Full Camera stays fully reachable: the C shortcut and the AI agent tool both call the same gated addCameraFullscreen store action, and the timeline lane still renders/edits existing camera-fullscreen regions.
  • Drop the two tests that asserted the removed button's enabled/disabled state, and the now-orphaned buttons.addCameraFullscreen string from all 13 locales.

Related issue

No tracked issue — reported directly by screenshot, confirmed non-functional by reading the code path. See #466 for the original review discussion.

Type of change

  • Bug fix

Release impact

  • Patch

Desktop impact

  • Not platform-specific

Screenshots / video

Not attached — this removes one existing toolbar icon (Maximize2, "Add Full Camera") with no other visual change.

Testing

Cherry-picked commit is identical in content to the one already merged and verified on main (#466). Re-ran on top of release/v1.10.0 (currently 1.10.0-rc.1):

  • npx vitest run over the affected suites — 71 tests pass
  • npx biome check on all changed files — clean
  • npx tsc --noEmit — clean
  • npm run i18n:check — all 12 locales still match en

Cherry-picked cleanly with no conflicts (git cherry-pick, same 16-file diff).

🤖 Generated with Claude Code

The button always looked clickable but silently no-opped on any project
without a webcam clip. Add Full Camera stays reachable via the C shortcut
and the AI agent tool, both of which already gate on hasAnyClipWithCamera
(#353) and are unaffected by this change.
@coderabbitai

coderabbitai Bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 33ddc997-a743-4cd5-91df-311de971e985

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@EtienneLescot

Copy link
Copy Markdown
Collaborator Author

Fermeture : le bouton visé n'était pas celui-ci ("Add Full Camera") mais un autre bouton "fullscreen" — je reverte #466 sur main en parallèle.

@EtienneLescot

Copy link
Copy Markdown
Collaborator Author

Ré-ouverture : #466 était bien le bon fix, la confusion portait juste sur le nom du bouton. Ce cherry-pick vers release/v1.10.0 redevient valide.

@EtienneLescot EtienneLescot reopened this Aug 22, 2026
@EtienneLescot

Copy link
Copy Markdown
Collaborator Author

Fermeture : #466 était en fait une erreur — le grisé/disabled du bouton "Add Full Camera" est le comportement voulu (#353), pas un bug. Ce cherry-pick n'a plus lieu d'être.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant