Errors are sometimes thrown with "warn" option

[panrafal]

This is a:

• Bug Report

Which concerns:

• flow-runtime

---

What is the current behaviour?

With the warn: true option, some invariants may still throw errors, for example this one: https://github.com/codemix/flow-runtime/blob/13e72fcc064bb6060c9ba49c58be3efe2f20ff40/packages/flow-runtime/src/flowTypes/%24ShapeType.js#L64

---

What is the expected behaviour?

Runtime should log a warning.

---

Which package versions are you using?

flow-runtime: 0.12

---

warn function (https://github.com/codemix/flow-runtime/blob/8bfdd7461f34d74bcb60247bf9b4b5644ab9e3b0/packages/flow-runtime/src/TypeContext.js#L1004) runs validation, but doesn't protect it from thrown errors

---

IssueHunt Summary

Backers (Total: $20.00)

• issuehunt ($20.00)

Submitted pull Requests

• #299 fix: avoid throwing in warn mode when validation internals fail

---

Become a backer now!

Or submit a pull request to get the deposits!

Tips

• Checkout the Issuehunt explorer to discover more funded issues.
• Need some help from other developers? Add your repositories on IssueHunt to raise funds.

[issuehunt-oss]

@issuehunt has funded $20.00 to this issue.

---

• Submit pull request via IssueHunt to receive this reward.
• Want to contribute? Chip in to this issue via IssueHunt.
• Checkout the IssueHunt Issue Explorer to see more funded issues.
• Need help from developers? Add your repository on IssueHunt to raise funds.

[robinchen0127-star]

I’m looking into this and plan to submit a PR shortly via IssueHunt. My plan is to reproduce the current warn: true behavior on the latest code, patch the warning path so thrown invariants do not escape, and add a regression test around the $ShapeType case described here.

[robinchen0127-star]

Update: I’ve opened PR #283 with a focused fix for the warn-mode regression plus tests. If you’d prefer the PR submitted through IssueHunt’s UI only, I can mirror it there as well.