Skip to content

Better error handling #238

Description

@bonsairobo

For example do_test_on_package does not return a Result, but instead it just manages a failed bool and keeps running through the code without early returns. We end up with sub-standard error reporting where the process fails and just prints:

ERROR cargo_fslabscli: Could not execute command: tests failed

Even with -vvvv that's all we get.

We should do some refactoring to make sure errors are not dropped so quickly.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions