Skip to content

Implement Charge Stance properly #1

Description

@fatcerberus

Charge Stance was implemented very lazily; it just takes the first action of Charge Slash and prepends that to the selected move's actions. This causes the turn preview to be incorrect and requires the engine to modify the skill data prior to queuing actions, which may have other unforeseen issues.

Ideally, the Charge turn should be implemented as a basic action in the battle engine, tied to the Stance. Modifying skill data on-the-fly outside of a status or field condition is tacky so it would be best to avoid any solution involving such manipulation.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions