chore: fix skill discovery warnings + document skills.sh install - #37
Merged
Conversation
The skills.sh walker (npx skills add) discovers any file named SKILL.md under .claude/, .codex/, and docs/, then rejects the three repo-root copies because they lack YAML frontmatter — printing a "Skipped … missing required frontmatter" warning on every install. Those three files were stale, unmaintained duplicates of the canonical skills/deployhq/SKILL.md (already drifted from 8100 bytes down to 3302/4898). No code reads them — the installer embeds skills/deployhq via //go:embed — only one README line referenced them (and it also listed .cursor/SKILL.md and .windsurf/SKILL.md, which don't exist). - Delete .claude/SKILL.md, .codex/SKILL.md, docs/SKILL.md - Preserve the two agent-facing examples unique to docs/SKILL.md (`dhq api GET /account/capabilities` and `POST /beta/enrollments`) into skills/deployhq/references/launch.md so no content is lost - Point the README reference at the canonical skills/deployhq/SKILL.md - Add a skills.sh badge under the tagline - Add an "Install as an agent skill (skills.sh)" subsection Verified: `npx skills add deployhq/deployhq-cli` now reports "Found 1 skill" with zero frontmatter warnings. Canonical SKILL.md untouched; go build/vet/lint and skillinstaller+commands tests pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughAgent skill documentation is consolidated around ChangesAgent skill documentation
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@skills/deployhq/references/launch.md`:
- Line 83: Specify the bash language on the fenced code block in the launch
documentation by adding the appropriate language identifier to the fence,
without changing the example content.
- Around line 84-85: Update the documented capabilities API command to use the
SDK-supported GET /profile endpoint instead of GET /account/capabilities, while
preserving the documented beta_features, static_hosting_eligible, and
managed_vps_eligible response fields.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 1e24d7d4-6b7c-4cb4-9b41-b6bc161672c5
📒 Files selected for processing (5)
.claude/SKILL.md.codex/SKILL.mdREADME.mddocs/SKILL.mdskills/deployhq/references/launch.md
💤 Files with no reviewable changes (3)
- docs/SKILL.md
- .claude/SKILL.md
- .codex/SKILL.md
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 45d903f71f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Address CodeRabbit review on #37: - The ported example used `dhq api GET /account/capabilities`, which is not a real endpoint. The SDK's GetAccountCapabilities reads the flags from the `account` sub-object of GET /profile (pkg/sdk/managed_hosting.go:19-24), so the documented escape hatch would have 404'd. Corrected to GET /profile and noted the flags live under `account.*`. - Tag the fenced example `bash` (matches launch.md:14). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Running
npx skills add deployhq/deployhq-cli(vercel-labs skills.sh) installs the canonical skill correctly, but the walker discovers any file namedSKILL.mdin the repo and rejects three of them for missing YAML frontmatter, printing this on every install:Those three files were stale, unmaintained duplicates of the canonical
skills/deployhq/SKILL.md(already drifted from 8100 bytes down to 3302/4898). No Go code reads them — the installer embedsskills/deployhqvia//go:embed— and only one README line referenced them (a line that also listed.cursor/SKILL.mdand.windsurf/SKILL.md, neither of which exists).Changes
.claude/SKILL.md,.codex/SKILL.md,docs/SKILL.md.docs/SKILL.md—dhq api GET /account/capabilitiesanddhq api POST /beta/enrollments— intoskills/deployhq/references/launch.md, so the deletion loses no content. (The managed_hosting regions/sizes examples were already covered there.)skills/deployhq/SKILL.md.npx skills add deployhq/deployhq-cli(the cross-agent equivalent ofdhq skills install).skills/deployhq/SKILL.mdis untouched — it remains the canonical, spec-valid skill.Verification
npx skills add deployhq/deployhq-clinow reports exactly "Found 1 skill" with zero "Skipped … missing required frontmatter" warnings.go build,go vet,golangci-lint run, andgo test ./internal/skillinstaller/... ./internal/commands/...all pass..goreleaser.yaml, eval scripts, CI) referenced the deleted paths.Reviewed by a multi-agent review council
Claude + Codex (GPT-5.5) reviewed the diff; both approved with one shared low-priority suggestion — preserve the lost
/account/capabilities//beta/enrollmentsexamples — which is addressed above.Note (external, not blocking)
The skills.sh badge renders (HTTP 200 SVG) but currently shows the label "resource not found" because
deployhq/deployhq-cliisn't indexed in the skills.sh directory yet. Thenpxinstall works regardless (it resolves the GitHub repo directly). The badge label will populate automatically once the repo is listed in the skills.sh directory.🤖 Generated with Claude Code
Summary by CodeRabbit
skills/deployhq/SKILL.md) and clarified installation methods.