Skip to content

Support for Windows #17

Description

@derinsh0

Dash-docs doesn't work correctly on Windows, most likely due to how external commands are handled and syntax. When looking up a symbol with helm-dash for example, dash-docs will correctly find the docset that includes that symbol, but clicking enter will open a dash-docs-errors buffer with

----------------
 HEY! This is dash-docs (sqlite) error logging. If you want to disable it, set `dash-docs-enable-debugging` to nil
---------------- 



cannot open: "''"

cannot open: "''"

cannot open: "''"

cannot open: "''"

cannot open: "''"

cannot open: "''"

cannot open: "''"

cannot open: "''"

cannot open: "''"

cannot open: "''"

cannot open: "''"

cannot open: "''"

cannot open: "''"

cannot open: "''"

cannot open: "''"

cannot open: "''"

cannot open: "''"

cannot open: "''"

cannot open: "''"

cannot open: "''"

cannot open: "''"

cannot open: "''"

cannot open: "''"

cannot open: "''"

(There is a ^L between every line)

And the message helm-M-x-execute-command: ShellExecute failed: The system cannot find the file specified.

I've made sure I'm using windows-version of sqlite3.

I'm assuming it's related to call-process in

(defun dash-docs-sql (db-path sql)
  "Run in the db located at DB-PATH the SQL command and parse the results.
If there are errors, print them in `dash-docs-debugging-buffer'"
  (dash-docs-parse-sql-results
   (with-output-to-string
     (let ((error-file (when dash-docs-enable-debugging
                         (make-temp-file "dash-docs-errors-file"))))
       (call-process "sqlite3" nil (list standard-output error-file) nil
                     ;; args for sqlite3:
                     "-list" "-init" "''" db-path sql)
...

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions