Skip to content

FFI: verify MultiQuery against v0.6.0 structure #174

Description

@s2x

Phase 1 — verification

v0.6.0 MultiQuery/SubQuery:

struct SubQuery {
  QueryTarget target_;
  int num_candidates_{10};
};
struct MultiQuery {
  std::vector<SubQuery> queries;
  int topk{10};
  std::string filter;
  bool include_vector{false};
  bool include_doc_id_{false};
  std::optional<std::vector<std::string>> output_fields_;
};

Tasks

  • Check our queryMulti FFI path compiles and maps correctly to SubQuery.target_
  • Rerank interface was switched to vector-based in v0.5.0 (#267) — our rerankers are pure PHP (no FFI), confirm no impact
  • tests/ covering queryMulti pass

Depends on: #170, #171.

Metadata

Metadata

Assignees

No one assigned

    Labels

    priority:mediumMedium prioritytaskTask migrated from tasks/

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions