Sunrise and sunset - wrong calculations

[amoledwatchfaces]

Hello, can you check this? It appears that the computed sunrise time is always afternoon and sunset in the morning, also the resulted times are not correct too?

[amoledwatchfaces]

Quick test from the library with this preset
val date = LocalDateTime.of(2013, 3, 5, 0, 0)
val latitude = 50.5
val longitude = 30.5

Output:
Sunrise: 2013-03-05T14:58:53.164

Sunrise should happen in the morning, not afternoon.

[amoledwatchfaces]

Two things. Looks like in one of the functions return, set is before rise, it needs to be switched so the sunrise time is is returned in sunrise object. One of the functions uses cos instead of acos, this is causing wrong calculations too. There is still some unknown issue as sunrise / sunset is still off by 2 minutes CA

[costular]

Hello @amoledwatchfaces,

Thank you for reaching out and for your interest in the sunkalc project. I wanted to inform you that the sunrise/sunset feature is currently incomplete and not functioning as intended. This is primarily because I haven't had sufficient time to fully develop and refine this aspect of the project. Additionally, I have not been actively using or maintaining sunkalc recently, which has contributed to its current state.

However, I truly appreciate your initiative and would be more than happy to welcome contributions to the project. If you're willing and able to work on fixing and improving the sunrise/sunset functionality, please feel free to submit a pull request. I will make sure to review it and provide feedback or merge it as appropriate.

Your contribution could be a valuable addition to sunkalc, and I'm excited to see how you might enhance its capabilities 😊