diff --git a/pkg/sql/colexec/and_or_projection.eg.go b/pkg/sql/colexec/and_or_projection.eg.go index 9352369fa428..186e4b4207c2 100644 --- a/pkg/sql/colexec/and_or_projection.eg.go +++ b/pkg/sql/colexec/and_or_projection.eg.go @@ -190,7 +190,6 @@ func (o *andProjOp) Init(ctx context.Context) { // side projection only on the remaining tuples (i.e. those that were not // "subtracted"). Next, it restores the original selection vector and // populates the result of the logical operation. -// func (o *andProjOp) Next() coldata.Batch { batch := o.input.Next() origLen := batch.Length() @@ -626,7 +625,6 @@ func (o *andRightNullProjOp) Init(ctx context.Context) { // side projection only on the remaining tuples (i.e. those that were not // "subtracted"). Next, it restores the original selection vector and // populates the result of the logical operation. -// func (o *andRightNullProjOp) Next() coldata.Batch { batch := o.input.Next() origLen := batch.Length() @@ -1029,7 +1027,6 @@ func (o *andLeftNullProjOp) Init(ctx context.Context) { // side projection only on the remaining tuples (i.e. those that were not // "subtracted"). Next, it restores the original selection vector and // populates the result of the logical operation. -// func (o *andLeftNullProjOp) Next() coldata.Batch { batch := o.input.Next() origLen := batch.Length() @@ -1413,7 +1410,6 @@ func (o *orProjOp) Init(ctx context.Context) { // side projection only on the remaining tuples (i.e. those that were not // "subtracted"). Next, it restores the original selection vector and // populates the result of the logical operation. -// func (o *orProjOp) Next() coldata.Batch { batch := o.input.Next() origLen := batch.Length() @@ -1850,7 +1846,6 @@ func (o *orRightNullProjOp) Init(ctx context.Context) { // side projection only on the remaining tuples (i.e. those that were not // "subtracted"). Next, it restores the original selection vector and // populates the result of the logical operation. -// func (o *orRightNullProjOp) Next() coldata.Batch { batch := o.input.Next() origLen := batch.Length() @@ -2254,7 +2249,6 @@ func (o *orLeftNullProjOp) Init(ctx context.Context) { // side projection only on the remaining tuples (i.e. those that were not // "subtracted"). Next, it restores the original selection vector and // populates the result of the logical operation. -// func (o *orLeftNullProjOp) Next() coldata.Batch { batch := o.input.Next() origLen := batch.Length() diff --git a/pkg/sql/colexec/and_or_projection_tmpl.go b/pkg/sql/colexec/and_or_projection_tmpl.go index 723814d45a53..f45f5403fc54 100644 --- a/pkg/sql/colexec/and_or_projection_tmpl.go +++ b/pkg/sql/colexec/and_or_projection_tmpl.go @@ -155,6 +155,16 @@ func (o *_OP_LOWERProjOp) Init(ctx context.Context) { o.rightProjOpChain.Init(o.Ctx) } +// {{/* +// TODO(yuzefovich): this operator is a bit sketchy because it works only +// under the assumption that the projection arms return exactly the same +// batch as they are fed (i.e. the projection operators aren't allowed to +// populate their own output batches from scratch) and that the deselection +// step isn't performed. Refactor this to make more resilient, and this will +// allow for simplifying the CASE operator by planning a deselector on top +// of its input. +// */}} + // Next is part of the colexecop.Operator interface. // The idea to handle the short-circuiting logic is similar to what caseOp // does: a logical operator has an input and two projection chains. First, @@ -165,15 +175,6 @@ func (o *_OP_LOWERProjOp) Init(ctx context.Context) { // side projection only on the remaining tuples (i.e. those that were not // "subtracted"). Next, it restores the original selection vector and // populates the result of the logical operation. -// {{/* -// TODO(yuzefovich): this operator is a bit sketchy because it works only -// under the assumption that the projection arms return exactly the same -// batch as they are fed (i.e. the projection operators aren't allowed to -// populate their own output batches from scratch) and that the deselection -// step isn't performed. Refactor this to make more resilient, and this will -// allow for simplifying the CASE operator by planning a deselector on top -// of its input. -// */}} func (o *_OP_LOWERProjOp) Next() coldata.Batch { batch := o.input.Next() origLen := batch.Length()