Skip to content

Present post-turn review and validation as one coherent completion block #784

Description

@shiny-code-bot

Finish Line

A completed root turn has one coherent completion surface: the assistant result, automatic Validation status, and Background Review status are ordered, labeled, and readable without late raw output looking like another assistant response.

Current Status

State: active with a current-head post-turn lifecycle reproduction on August 24, 2026.

In #787 amendment session 01a03136-7d5d-71e3-affd-25fd81b274ac:

  • The assistant final was persisted at 00:52:09 UTC and reported implementation completion while both automatic lifecycle gates were still unsettled.
  • Automatic Validation reached terminal timed_out at 00:52:40 UTC, 30.017 seconds later, with exit code 124 and no compiler diagnostic.
  • Background Review started in separate thread 01a03141-5e27-71f1-9fa1-6518decfffb3 and completed at 00:54:17 UTC with one token-density finding, overall_correctness=patch is incorrect, and confidence 0.86.
  • The terminal review result arrived more than two minutes after the primary assistant handoff and materially changed the readiness verdict from apparently complete to not ready.

This is stronger evidence than the prior clean late review: the missing coherent completion surface did not merely hide supplementary information; it hid a blocking current-head correctness result until after the primary answer and PR push.

The underlying AGENTS token-cap defect belongs to #787 and the Cargo timeout belongs to #785. This issue owns the lifecycle persistence, ordering, and presentation failure.

Next action: make the root completion surface explicitly own pending Validation/Background Review state and update it in place when late terminal results arrive. Include replay/resume and snapshot coverage where a delayed review changes the final readiness verdict.

Blocked by: lifecycle/presentation design.

Last verified: August 24, 2026.

Acceptance Criteria

  • The final assistant surface does not imply all completion gates are settled while Validation or Background Review is still pending.
  • Late lifecycle results render in a clearly labeled post-turn section or card, not as an apparent continuation of assistant prose.
  • Background Review renders a concise human-readable verdict; raw JSON remains available only as bounded detail.
  • Validation and Background Review ordering is deterministic across live turns, replay, resume, and history projection.
  • TUI snapshots cover pending, passed, skipped, failed, and delayed-review states.
  • Installed-artifact dogfood confirms the final result remains readable while post-turn work completes.

Relationships

Metadata

Metadata

Assignees

No one assigned

    Labels

    planDurable planning issueplan:activePlan is actionable now

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions