DI Tokens are timing out every few days

[yeled]

Are you finding your omramin scripts need re-authenticating regularly?

In my own projects, using this garmin_client instead means the tokens are never outdated, only refreshed.

Just wondering if it's me or you are seeing this too.

[gitthangbaby]

Yes it works only for ~2 days

garminconnect.exceptions.GarminConnectConnectionError: API Error 401
garminconnect.exceptions.GarminConnectAuthenticationError: Failed to retrieve social profile
Inappropriate ioctl for device

[prashker]

Yes recurring issue, have to reauth

[ninjazx12r]

Yes same issue.

[prashker]

tl;dr - Attempted a fix, if it works I'll do a PR: prashker@23b3c94

---

Did a little sleuthing. The upstream garminconnect library seems to have logic to refresh tokens, but I think there is a flaw in the successful login block of omramin.

Note a login failure, save_service_tokens is only called if cached login fails and except is triggered

omramin/omramin.py

Line 295 in f6b6623

except (FileNotFoundError, binascii.Error, KeyError, GC.GarminConnectAuthenticationError):

omramin/omramin.py

Lines 379 to 380 in f6b6623

	# Save tokens to keyring
	save_service_tokens(config_path, "garmin", email, gc.client.dumps()) # pylint: disable=no-member

I think if we add the save_service_tokens(...) to the successful login try it may fix the issue.

omramin/omramin.py

Lines 279 to 293 in f6b6623

	try:
	# Load tokens from keyring (requires email)
	tokendata = None
	if email:
	tokendata = load_service_tokens(config_path, "garmin", email, migrate_from_config=config)
	if not tokendata:
	raise FileNotFoundError
	is_cn = gcCfg.get("is_cn", False)
	gc = GC.Garmin(email=email, is_cn=is_cn, prompt_mfa=get_mfa)
	L.debug(f"Attempting Garmin login using cached tokens for {email}")
	gc.login(tokenstore=tokendata)
	L.debug(f"Garmin login successful using cached tokens for {email}")

def garmin_login(config_path: str) -> T.Optional[GC.Garmin]:
    """Login to Garmin Connect"""

    try:
        config = U.json_load(config_path)

    except FileNotFoundError:
        config = DEFAULT_CONFIG.copy()

    gcCfg = config.get("garmin", {})

    # Get email from config or env
    email = _E("GARMIN_EMAIL") or gcCfg.get("email", "")

    def get_mfa() -> str:
        return inquirer.text(message="> Enter MFA/2FA code")

    try:
        # Load tokens from keyring (requires email)
        tokendata = None
        if email:
            tokendata = load_service_tokens(config_path, "garmin", email, migrate_from_config=config)

        if not tokendata:
            raise FileNotFoundError

        is_cn = gcCfg.get("is_cn", False)
        gc = GC.Garmin(email=email, is_cn=is_cn, prompt_mfa=get_mfa)

        L.debug(f"Attempting Garmin login using cached tokens for {email}")
        gc.login(tokenstore=tokendata)
        L.debug(f"Garmin login successful using cached tokens for {email}")

        # NEW NEW NEW Save tokens back to keyring in case they were proactively refreshed during login
        save_service_tokens(config_path, "garmin", email, gc.client.dumps())

I applied this change locally, I'll see if I stay logged in over the course of a few days.

[prashker]

Submitted a PR, been running my above change for 7 days and seems to still be working