Skip to content

buckaroo_pick_file is a stub — track real implementation #2

Description

@paddymul

Status

buckaroo_pick_file (crates/buckaroo-tauri/src/commands.rs:132-145) currently returns an error stub. The README acknowledges this:

buckaroo_pick_file() → `string | null` — stub; use tauri-plugin-dialog until v1.1

Filing for visibility / tracking — no urgency from my side (host apps can wire tauri-plugin-dialog themselves, which is what xorq-desktop will do).

Suggested resolution options

  1. Remove the stub and document tauri-plugin-dialog as the official pattern; one fewer permission surface in the plugin.
  2. Implement it by re-exporting a thin wrapper around tauri-plugin-dialog::FileDialogBuilder, scoped to common dataframe extensions (.parquet, .csv, .arrow, .feather, .ipc).

Option 1 is probably the right call — the dialog plugin is the standard, and bundling it inside buckaroo-tauri couples the crate to a UI concern. If kept as a stub, the README note should escalate from "until v1.1" to either a concrete milestone or a #[deprecated] attribute.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions