Skip to content

[core] Set default-features = false for serde dependency #2208

Description

@ValuedMammal

Both bdk_core and bdk_chain declare their serde dependency without default-features = false.

Because serde's default feature set includes std, enabling the bdk_chain/serde feature in a downstream no_std crate activates serde/std via Cargo's feature unification. On bare-metal targets where std is unavailable this produces a compile error in serde_core.

Expected behavior

Enabling bdk_chain/serde in a no_std + alloc project should not activate serde/std. The fix is straightforward: add default-features = false to the serde dep in both bdk_core and bdk_chain, and propagate serde/std through their existing std feature.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    dependenciesPull requests that update a dependency file

    Type

    No type

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions