From cd09d8cf93d680cf3eb1221710ebda8fa5b24786 Mon Sep 17 00:00:00 2001 From: artcom Date: Mon, 27 Apr 2026 02:04:07 +0300 Subject: [PATCH 01/21] Setup dev CI with pre-commit and msvc builds --- .github/workflows/dev_ci.yml | 45 ++++++++++++++++++++++++++++++++++++ 1 file changed, 45 insertions(+) create mode 100644 .github/workflows/dev_ci.yml diff --git a/.github/workflows/dev_ci.yml b/.github/workflows/dev_ci.yml new file mode 100644 index 0000000..a9bb71b --- /dev/null +++ b/.github/workflows/dev_ci.yml @@ -0,0 +1,45 @@ +name: dev-ci +run-name: ${{ github.actor }} is building Mayones +on: [push] + +jobs: + + build: + name: Build + runs-on: windows-latest + + steps: + - name: Checkout + uses: actions/checkout@v6 + + # - name: Setup LLVM + # run: choco install llvm --version 21.1.3 + + # - name: Setup Python + # uses: actions/setup-python@v3 + + - name: Setup vcpkg + uses: lukka/run-vcpkg@v11 + + - name: Setup CMake + uses: lukka/get-cmake@v4.2 + + - name: Configure build + uses: lukka/run-cmake@v10 + with: + configurePreset: 'msvc-debug' + + - name: Pre-commit + uses: pre-commit/action@v3.0.1 + with: + extra_args: --all-files + + - name: Build + uses: lukka/run-cmake@v10 + with: + buildPreset: 'msvc-debug' + + - name: Test + uses: lukka/run-cmake@v10 + with: + testPreset: 'msvc-debug' From 55d76d30372e6fbb178345b29250a49b3461527e Mon Sep 17 00:00:00 2001 From: artcom Date: Mon, 27 Apr 2026 02:09:52 +0300 Subject: [PATCH 02/21] Fix setup cmake error --- .github/workflows/dev_ci.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/dev_ci.yml b/.github/workflows/dev_ci.yml index a9bb71b..c49fbf0 100644 --- a/.github/workflows/dev_ci.yml +++ b/.github/workflows/dev_ci.yml @@ -22,7 +22,10 @@ jobs: uses: lukka/run-vcpkg@v11 - name: Setup CMake - uses: lukka/get-cmake@v4.2 + uses: lukka/get-cmake@latest + with: + cmakeVersion: "^4.2.3" + ninjaVersion: "^1.13.2" - name: Configure build uses: lukka/run-cmake@v10 From 1c239ab6d082d9557e8aaca0c40d33e2d5adb893 Mon Sep 17 00:00:00 2001 From: artcom Date: Mon, 27 Apr 2026 02:33:14 +0300 Subject: [PATCH 03/21] Fix CI errors --- .github/workflows/dev_ci.yml | 1 + .pre-commit-config.yaml | 18 +++++++++--------- 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/.github/workflows/dev_ci.yml b/.github/workflows/dev_ci.yml index c49fbf0..3318808 100644 --- a/.github/workflows/dev_ci.yml +++ b/.github/workflows/dev_ci.yml @@ -31,6 +31,7 @@ jobs: uses: lukka/run-cmake@v10 with: configurePreset: 'msvc-debug' + configurePresetAdditionalArgs: "['-DBUILD_TESTING=ON']" - name: Pre-commit uses: pre-commit/action@v3.0.1 diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 533ca38..207bd0c 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -27,12 +27,12 @@ repos: types_or: [c++] files: ^(src|tests)/ - - repo: local - hooks: - - id: clang-tidy - name: clang-tidy - entry: clang-tidy - args: ["-p=."] - language: system - types_or: [c++] - files: ^(src|tests)/ + # - repo: local + # hooks: + # - id: clang-tidy + # name: clang-tidy + # entry: clang-tidy + # args: ["-p=."] + # language: system + # types_or: [c++] + # files: ^(src|tests)/ From 4f8d81db99fe8d61479b6a7986f320397ce8b920 Mon Sep 17 00:00:00 2001 From: artcom Date: Mon, 27 Apr 2026 02:39:08 +0300 Subject: [PATCH 04/21] Enable verbose build --- CMakePresets.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CMakePresets.json b/CMakePresets.json index 7e625dc..4794bc6 100644 --- a/CMakePresets.json +++ b/CMakePresets.json @@ -67,7 +67,8 @@ "buildPresets": [ { "name": "msvc-debug", - "configurePreset": "msvc-debug" + "configurePreset": "msvc-debug", + "verbose": true }, { "name": "msvc-release", From 0ff720b521c988563eccbc8aa9f00e7a3a1fe95e Mon Sep 17 00:00:00 2001 From: artcom Date: Mon, 27 Apr 2026 02:49:48 +0300 Subject: [PATCH 05/21] Use windows-2025-vs2026 image for pipeline --- .github/workflows/dev_ci.yml | 2 +- .pre-commit-config.yaml | 18 +++++++++--------- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/.github/workflows/dev_ci.yml b/.github/workflows/dev_ci.yml index 3318808..81ff906 100644 --- a/.github/workflows/dev_ci.yml +++ b/.github/workflows/dev_ci.yml @@ -6,7 +6,7 @@ jobs: build: name: Build - runs-on: windows-latest + runs-on: windows-2025-vs2026 steps: - name: Checkout diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 207bd0c..533ca38 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -27,12 +27,12 @@ repos: types_or: [c++] files: ^(src|tests)/ - # - repo: local - # hooks: - # - id: clang-tidy - # name: clang-tidy - # entry: clang-tidy - # args: ["-p=."] - # language: system - # types_or: [c++] - # files: ^(src|tests)/ + - repo: local + hooks: + - id: clang-tidy + name: clang-tidy + entry: clang-tidy + args: ["-p=."] + language: system + types_or: [c++] + files: ^(src|tests)/ From ff48c882ff78fa52ab368f6731abdb9c01c85332 Mon Sep 17 00:00:00 2001 From: artcom Date: Mon, 27 Apr 2026 03:05:22 +0300 Subject: [PATCH 06/21] Run clang-tidy after build --- .github/workflows/dev_ci.yml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/.github/workflows/dev_ci.yml b/.github/workflows/dev_ci.yml index 81ff906..77bc981 100644 --- a/.github/workflows/dev_ci.yml +++ b/.github/workflows/dev_ci.yml @@ -35,6 +35,8 @@ jobs: - name: Pre-commit uses: pre-commit/action@v3.0.1 + env: + SKIP: clang-tidy with: extra_args: --all-files @@ -43,6 +45,11 @@ jobs: with: buildPreset: 'msvc-debug' + - name: clang-tidy + uses: pre-commit/action@v3.0.1 + with: + extra_args: --all-files clang-tidy + - name: Test uses: lukka/run-cmake@v10 with: From 8d28b9791926589696a57fc3f70b359d01dfbdb4 Mon Sep 17 00:00:00 2001 From: artcom Date: Mon, 27 Apr 2026 03:34:23 +0300 Subject: [PATCH 07/21] Set explicit path to compilation database for clang-tidy in CI --- .pre-commit-config.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 533ca38..4ad3fb0 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -32,7 +32,7 @@ repos: - id: clang-tidy name: clang-tidy entry: clang-tidy - args: ["-p=."] + args: ["-p=./out/build/msvc-debug"] language: system types_or: [c++] files: ^(src|tests)/ From 8e483611fd2c817df4ea0554378eee58c3bb80da Mon Sep 17 00:00:00 2001 From: artcom Date: Mon, 27 Apr 2026 03:44:01 +0300 Subject: [PATCH 08/21] Set explicit C++ standard for clang-tidy in CI --- .pre-commit-config.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 4ad3fb0..a2b9d1a 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -32,7 +32,7 @@ repos: - id: clang-tidy name: clang-tidy entry: clang-tidy - args: ["-p=./out/build/msvc-debug"] + args: ["-p=.", "-extra-arg=/std:c++latest"] language: system types_or: [c++] files: ^(src|tests)/ From 5c5a31597fad02f5d898999a18ad2b16b65ff059 Mon Sep 17 00:00:00 2001 From: artcom Date: Mon, 27 Apr 2026 03:59:35 +0300 Subject: [PATCH 09/21] Setup clang-tidy latest from pypi --- .github/workflows/dev_ci.yml | 4 ++-- .pre-commit-config.yaml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/dev_ci.yml b/.github/workflows/dev_ci.yml index 77bc981..00af1e4 100644 --- a/.github/workflows/dev_ci.yml +++ b/.github/workflows/dev_ci.yml @@ -12,8 +12,8 @@ jobs: - name: Checkout uses: actions/checkout@v6 - # - name: Setup LLVM - # run: choco install llvm --version 21.1.3 + - name: Setup clang-tidy + run: pip install clang-tidy==22.1.0.1 # - name: Setup Python # uses: actions/setup-python@v3 diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index a2b9d1a..533ca38 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -32,7 +32,7 @@ repos: - id: clang-tidy name: clang-tidy entry: clang-tidy - args: ["-p=.", "-extra-arg=/std:c++latest"] + args: ["-p=."] language: system types_or: [c++] files: ^(src|tests)/ From a84f9d30b92ee6f4faf9d3aaf82fbc15dbe5f78c Mon Sep 17 00:00:00 2001 From: artcom Date: Mon, 27 Apr 2026 04:10:29 +0300 Subject: [PATCH 10/21] Setup clang-format latest from pypi --- .github/workflows/dev_ci.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/dev_ci.yml b/.github/workflows/dev_ci.yml index 00af1e4..b05a8c1 100644 --- a/.github/workflows/dev_ci.yml +++ b/.github/workflows/dev_ci.yml @@ -13,10 +13,10 @@ jobs: uses: actions/checkout@v6 - name: Setup clang-tidy - run: pip install clang-tidy==22.1.0.1 - - # - name: Setup Python - # uses: actions/setup-python@v3 + run: | + pip install clang-tidy==22.1.0.1 clang-format==22.1.3 + clang-tidy --version + clang-format --version - name: Setup vcpkg uses: lukka/run-vcpkg@v11 From 6afb4075a8d30e2e8354dad1cdc81bd9211e1d83 Mon Sep 17 00:00:00 2001 From: artcom Date: Mon, 27 Apr 2026 04:31:19 +0300 Subject: [PATCH 11/21] Run clang-tidy as part of pre-commit --- .github/workflows/dev_ci.yml | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/dev_ci.yml b/.github/workflows/dev_ci.yml index b05a8c1..517b83d 100644 --- a/.github/workflows/dev_ci.yml +++ b/.github/workflows/dev_ci.yml @@ -1,6 +1,6 @@ name: dev-ci run-name: ${{ github.actor }} is building Mayones -on: [push] +on: push jobs: @@ -12,7 +12,7 @@ jobs: - name: Checkout uses: actions/checkout@v6 - - name: Setup clang-tidy + - name: Setup LLVM tools run: | pip install clang-tidy==22.1.0.1 clang-format==22.1.3 clang-tidy --version @@ -35,8 +35,8 @@ jobs: - name: Pre-commit uses: pre-commit/action@v3.0.1 - env: - SKIP: clang-tidy + # env: + # SKIP: clang-tidy with: extra_args: --all-files @@ -45,10 +45,10 @@ jobs: with: buildPreset: 'msvc-debug' - - name: clang-tidy - uses: pre-commit/action@v3.0.1 - with: - extra_args: --all-files clang-tidy + # - name: clang-tidy + # uses: pre-commit/action@v3.0.1 + # with: + # extra_args: --all-files clang-tidy - name: Test uses: lukka/run-cmake@v10 From dce9e36b99cb2dff4f40c91e1bdfff1aeaffabc5 Mon Sep 17 00:00:00 2001 From: artcom Date: Mon, 27 Apr 2026 08:18:57 +0300 Subject: [PATCH 12/21] Setup vcpkg binary cache --- .github/workflows/common.yml | 18 +++++++++ .github/workflows/dev.yml | 71 ++++++++++++++++++++++++++++++++++++ .github/workflows/dev_ci.yml | 56 ---------------------------- 3 files changed, 89 insertions(+), 56 deletions(-) create mode 100644 .github/workflows/common.yml create mode 100644 .github/workflows/dev.yml delete mode 100644 .github/workflows/dev_ci.yml diff --git a/.github/workflows/common.yml b/.github/workflows/common.yml new file mode 100644 index 0000000..7181949 --- /dev/null +++ b/.github/workflows/common.yml @@ -0,0 +1,18 @@ +name: common-pipeline +run-name: ${{ github.actor }} ran common checks +on: push + +jobs: + common-pipeline: + name: Pre-commit checks + runs-on: ubuntu-latest + steps: + - name: Checkout + uses: actions/checkout@v6 + + - name: Pre-commit + uses: pre-commit/action@v3.0.1 + env: + SKIP: clang-format,clang-tidy + with: + extra_args: --all-files diff --git a/.github/workflows/dev.yml b/.github/workflows/dev.yml new file mode 100644 index 0000000..5530c84 --- /dev/null +++ b/.github/workflows/dev.yml @@ -0,0 +1,71 @@ +name: dev-pipeline +run-name: ${{ github.actor }} is cooking MayoNES +permissions: + packages: write +on: + push: + paths: + - "src/**" + - "tests/**" + - "CMakeLists.txt" + - "vcpkg.json" + - ".pre-commit-config.yaml" + +env: + USERNAME: artcom-net + VCPKG_EXE: ${{ github.workspace }}/vcpkg/vcpkg + FEED_URL: https://nuget.pkg.github.com/artcom-net/index.json + VCPKG_BINARY_SOURCES: "clear;nuget,https://nuget.pkg.github.com/artcom-net/index.json,readwrite" + +jobs: + dev-pipeline: + name: dev-pipeline + runs-on: windows-2025-vs2026 + + steps: + - name: Checkout + uses: actions/checkout@v6 + + - name: Setup LLVM tools + run: pip install clang-tidy==22.1.0.1 clang-format==22.1.3 + + - name: clang-format + uses: pre-commit/action@v3.0.1 + with: + extra_args: --all-files clang-format + + - name: Setup vcpkg + uses: lukka/run-vcpkg@v11 + + - name: Add NuGet sources + shell: pwsh + run: | + .$(${{ env.VCPKG_EXE }} fetch nuget) ` + sources add ` + -Source "${{ env.FEED_URL }}" ` + -StorePasswordInClearText ` + -Name GitHubPackages ` + -UserName "${{ env.USERNAME }}" ` + -Password "${{ secrets.GITHUB_TOKEN }}" + .$(${{ env.VCPKG_EXE }} fetch nuget) ` + setapikey "${{ secrets.GITHUB_TOKEN }}" ` + -Source "${{ env.FEED_URL }}" + + - name: Setup CMake + uses: lukka/get-cmake@latest + with: + cmakeVersion: "^4.2.3" + ninjaVersion: "^1.13.2" + + - name: Build + uses: lukka/run-cmake@v10 + with: + configurePreset: "msvc-debug" + configurePresetAdditionalArgs: "['-DBUILD_TESTING=ON']" + buildPreset: "msvc-debug" + testPreset: "msvc-debug" + + - name: clang-tidy + uses: pre-commit/action@v3.0.1 + with: + extra_args: --all-files clang-tidy diff --git a/.github/workflows/dev_ci.yml b/.github/workflows/dev_ci.yml deleted file mode 100644 index 517b83d..0000000 --- a/.github/workflows/dev_ci.yml +++ /dev/null @@ -1,56 +0,0 @@ -name: dev-ci -run-name: ${{ github.actor }} is building Mayones -on: push - -jobs: - - build: - name: Build - runs-on: windows-2025-vs2026 - - steps: - - name: Checkout - uses: actions/checkout@v6 - - - name: Setup LLVM tools - run: | - pip install clang-tidy==22.1.0.1 clang-format==22.1.3 - clang-tidy --version - clang-format --version - - - name: Setup vcpkg - uses: lukka/run-vcpkg@v11 - - - name: Setup CMake - uses: lukka/get-cmake@latest - with: - cmakeVersion: "^4.2.3" - ninjaVersion: "^1.13.2" - - - name: Configure build - uses: lukka/run-cmake@v10 - with: - configurePreset: 'msvc-debug' - configurePresetAdditionalArgs: "['-DBUILD_TESTING=ON']" - - - name: Pre-commit - uses: pre-commit/action@v3.0.1 - # env: - # SKIP: clang-tidy - with: - extra_args: --all-files - - - name: Build - uses: lukka/run-cmake@v10 - with: - buildPreset: 'msvc-debug' - - # - name: clang-tidy - # uses: pre-commit/action@v3.0.1 - # with: - # extra_args: --all-files clang-tidy - - - name: Test - uses: lukka/run-cmake@v10 - with: - testPreset: 'msvc-debug' From a745398c8a766bbb66d9a08c67d1c4d527e11d78 Mon Sep 17 00:00:00 2001 From: artcom Date: Mon, 27 Apr 2026 08:22:49 +0300 Subject: [PATCH 13/21] Change source for dev pipeline testing --- src/app/app.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/app/app.cpp b/src/app/app.cpp index 52cf440..ac24a9e 100644 --- a/src/app/app.cpp +++ b/src/app/app.cpp @@ -14,6 +14,7 @@ MayoNES::MayoNES(Config config) : mayones::VERSION, m_config.rom_path.generic_string(), m_config.debug); + std::println("tmp changes"); } } // namespace mayones::app From 11591af71a44210eb8c038301c0f4e78a38b088d Mon Sep 17 00:00:00 2001 From: artcom Date: Mon, 27 Apr 2026 08:28:08 +0300 Subject: [PATCH 14/21] Revert app.cpp to previous state --- src/app/app.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/src/app/app.cpp b/src/app/app.cpp index ac24a9e..52cf440 100644 --- a/src/app/app.cpp +++ b/src/app/app.cpp @@ -14,7 +14,6 @@ MayoNES::MayoNES(Config config) : mayones::VERSION, m_config.rom_path.generic_string(), m_config.debug); - std::println("tmp changes"); } } // namespace mayones::app From dae457cbc25487e8b53eecd43d26529208b2b4d9 Mon Sep 17 00:00:00 2001 From: artcom Date: Tue, 28 Apr 2026 00:57:45 +0300 Subject: [PATCH 15/21] Update CI pipelines --- .github/workflows/common.yml | 1 + .github/workflows/dev.yml | 58 ++++++++++++++++++++++++------------ requirements-dev.txt | 2 ++ 3 files changed, 42 insertions(+), 19 deletions(-) create mode 100644 requirements-dev.txt diff --git a/.github/workflows/common.yml b/.github/workflows/common.yml index 7181949..2f6bd8a 100644 --- a/.github/workflows/common.yml +++ b/.github/workflows/common.yml @@ -1,5 +1,6 @@ name: common-pipeline run-name: ${{ github.actor }} ran common checks + on: push jobs: diff --git a/.github/workflows/dev.yml b/.github/workflows/dev.yml index 5530c84..bcfe43d 100644 --- a/.github/workflows/dev.yml +++ b/.github/workflows/dev.yml @@ -1,24 +1,38 @@ name: dev-pipeline run-name: ${{ github.actor }} is cooking MayoNES -permissions: - packages: write + on: + workflow_dispatch: + inputs: + cmake_preset: + description: "CMake preset" + required: true + default: msvc-debug + type: choice + options: + - msvc-debug + - msvc-release + push: paths: + - ".github/workflows/dev.yml" - "src/**" - "tests/**" + - ".pre-commit-config.yaml" - "CMakeLists.txt" - "vcpkg.json" - - ".pre-commit-config.yaml" - -env: - USERNAME: artcom-net - VCPKG_EXE: ${{ github.workspace }}/vcpkg/vcpkg - FEED_URL: https://nuget.pkg.github.com/artcom-net/index.json - VCPKG_BINARY_SOURCES: "clear;nuget,https://nuget.pkg.github.com/artcom-net/index.json,readwrite" jobs: dev-pipeline: + permissions: + packages: write + + env: + CMAKE_PRESET: msvc-debug + VCPKG_EXE: "${{ github.workspace }}/vcpkg/vcpkg" + NUGET_FEED_URL: "https://nuget.pkg.github.com/${{ github.repository_owner }}/index.json" + VCPKG_BINARY_SOURCES: "clear;nuget,https://nuget.pkg.github.com/${{ github.repository_owner }}/index.json,readwrite" + name: dev-pipeline runs-on: windows-2025-vs2026 @@ -26,13 +40,17 @@ jobs: - name: Checkout uses: actions/checkout@v6 - - name: Setup LLVM tools - run: pip install clang-tidy==22.1.0.1 clang-format==22.1.3 + - name: Setup Python deps + uses: actions/setup-python@v6 + with: + python-version: "3.13" + cache: pip + - run: pip install -r requirements-dev.txt - name: clang-format uses: pre-commit/action@v3.0.1 with: - extra_args: --all-files clang-format + extra_args: clang-format --all-files - name: Setup vcpkg uses: lukka/run-vcpkg@v11 @@ -42,14 +60,14 @@ jobs: run: | .$(${{ env.VCPKG_EXE }} fetch nuget) ` sources add ` - -Source "${{ env.FEED_URL }}" ` + -Source "${{ env.NUGET_FEED_URL }}" ` -StorePasswordInClearText ` -Name GitHubPackages ` - -UserName "${{ env.USERNAME }}" ` + -UserName "${{ github.repository_owner }}" ` -Password "${{ secrets.GITHUB_TOKEN }}" .$(${{ env.VCPKG_EXE }} fetch nuget) ` setapikey "${{ secrets.GITHUB_TOKEN }}" ` - -Source "${{ env.FEED_URL }}" + -Source "${{ env.NUGET_FEED_URL }}" - name: Setup CMake uses: lukka/get-cmake@latest @@ -59,13 +77,15 @@ jobs: - name: Build uses: lukka/run-cmake@v10 + env: + CMAKE_PRESET: "${{ inputs.cmake_preset || env.CMAKE_PRESET }}" with: - configurePreset: "msvc-debug" + configurePreset: "${{ env.CMAKE_PRESET }}" configurePresetAdditionalArgs: "['-DBUILD_TESTING=ON']" - buildPreset: "msvc-debug" - testPreset: "msvc-debug" + buildPreset: "${{ env.CMAKE_PRESET }}" + testPreset: "${{ env.CMAKE_PRESET }}" - name: clang-tidy uses: pre-commit/action@v3.0.1 with: - extra_args: --all-files clang-tidy + extra_args: clang-tidy --all-files diff --git a/requirements-dev.txt b/requirements-dev.txt new file mode 100644 index 0000000..04302f1 --- /dev/null +++ b/requirements-dev.txt @@ -0,0 +1,2 @@ +clang-format==22.1.3 +clang-tidy==22.1.0.1 From 52116407e6f363ab6ca04bd72723a7ad085d30b6 Mon Sep 17 00:00:00 2001 From: artcom Date: Tue, 28 Apr 2026 01:03:23 +0300 Subject: [PATCH 16/21] Correct path to requirements-dev.txt --- .github/workflows/dev.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/dev.yml b/.github/workflows/dev.yml index bcfe43d..9b06529 100644 --- a/.github/workflows/dev.yml +++ b/.github/workflows/dev.yml @@ -45,6 +45,7 @@ jobs: with: python-version: "3.13" cache: pip + cache-dependency-path: "requirements-dev.txt" - run: pip install -r requirements-dev.txt - name: clang-format From 5420fc72083a39fabfdef9ea2599897c43e29258 Mon Sep 17 00:00:00 2001 From: artcom Date: Tue, 28 Apr 2026 01:23:16 +0300 Subject: [PATCH 17/21] Use same Python version for common pipeline --- .github/workflows/common.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/common.yml b/.github/workflows/common.yml index 2f6bd8a..d1de83e 100644 --- a/.github/workflows/common.yml +++ b/.github/workflows/common.yml @@ -12,7 +12,10 @@ jobs: uses: actions/checkout@v6 - name: Pre-commit - uses: pre-commit/action@v3.0.1 + uses: actions/setup-python@v6 + with: + python-version: "3.13" + - uses: pre-commit/action@v3.0.1 env: SKIP: clang-format,clang-tidy with: From 5977371d10bbb664d9036631d2f26aec651a43c9 Mon Sep 17 00:00:00 2001 From: artcom Date: Tue, 28 Apr 2026 01:25:11 +0300 Subject: [PATCH 18/21] Changes for cache testing --- src/app/app.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/app/app.cpp b/src/app/app.cpp index 52cf440..ba61638 100644 --- a/src/app/app.cpp +++ b/src/app/app.cpp @@ -14,6 +14,7 @@ MayoNES::MayoNES(Config config) : mayones::VERSION, m_config.rom_path.generic_string(), m_config.debug); + std::println("\n"); } } // namespace mayones::app From 715cbc27fecbf06cf0a22a75e4cb2e525af09fa9 Mon Sep 17 00:00:00 2001 From: artcom Date: Tue, 28 Apr 2026 01:48:23 +0300 Subject: [PATCH 19/21] Minor final fixes --- .github/workflows/common.yml | 3 ++- .github/workflows/dev.yml | 6 +++--- src/app/app.cpp | 1 - 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/common.yml b/.github/workflows/common.yml index d1de83e..d662a1f 100644 --- a/.github/workflows/common.yml +++ b/.github/workflows/common.yml @@ -5,7 +5,8 @@ on: push jobs: common-pipeline: - name: Pre-commit checks + + name: pre-commit checks runs-on: ubuntu-latest steps: - name: Checkout diff --git a/.github/workflows/dev.yml b/.github/workflows/dev.yml index 9b06529..8bb4593 100644 --- a/.github/workflows/dev.yml +++ b/.github/workflows/dev.yml @@ -40,7 +40,7 @@ jobs: - name: Checkout uses: actions/checkout@v6 - - name: Setup Python deps + - name: Setup Python uses: actions/setup-python@v6 with: python-version: "3.13" @@ -56,7 +56,7 @@ jobs: - name: Setup vcpkg uses: lukka/run-vcpkg@v11 - - name: Add NuGet sources + - name: Setup NuGet shell: pwsh run: | .$(${{ env.VCPKG_EXE }} fetch nuget) ` @@ -76,7 +76,7 @@ jobs: cmakeVersion: "^4.2.3" ninjaVersion: "^1.13.2" - - name: Build + - name: Build & Test uses: lukka/run-cmake@v10 env: CMAKE_PRESET: "${{ inputs.cmake_preset || env.CMAKE_PRESET }}" diff --git a/src/app/app.cpp b/src/app/app.cpp index ba61638..52cf440 100644 --- a/src/app/app.cpp +++ b/src/app/app.cpp @@ -14,7 +14,6 @@ MayoNES::MayoNES(Config config) : mayones::VERSION, m_config.rom_path.generic_string(), m_config.debug); - std::println("\n"); } } // namespace mayones::app From d169ff73bb8b22322628ef3ea60ab3c88be15372 Mon Sep 17 00:00:00 2001 From: artcom Date: Tue, 28 Apr 2026 02:08:04 +0300 Subject: [PATCH 20/21] Turn off verbose for build --- CMakePresets.json | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/CMakePresets.json b/CMakePresets.json index 4794bc6..7e625dc 100644 --- a/CMakePresets.json +++ b/CMakePresets.json @@ -67,8 +67,7 @@ "buildPresets": [ { "name": "msvc-debug", - "configurePreset": "msvc-debug", - "verbose": true + "configurePreset": "msvc-debug" }, { "name": "msvc-release", From 86c22fea34739194ca6c8f459d70e408421a8749 Mon Sep 17 00:00:00 2001 From: artcom Date: Tue, 28 Apr 2026 02:11:23 +0300 Subject: [PATCH 21/21] Run dev-pipeline if CMakePresets has changed --- .github/workflows/dev.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/dev.yml b/.github/workflows/dev.yml index 8bb4593..7b934d1 100644 --- a/.github/workflows/dev.yml +++ b/.github/workflows/dev.yml @@ -20,6 +20,7 @@ on: - "tests/**" - ".pre-commit-config.yaml" - "CMakeLists.txt" + - "CMakePresets.json" - "vcpkg.json" jobs: