From ae6ca748f072c6d4673998b837dad977f9d12803 Mon Sep 17 00:00:00 2001 From: Shayn Hornik Date: Tue, 1 Sep 2026 14:28:10 -0400 Subject: [PATCH 1/2] Build: Correct LICENSE paths for wheels and document the bundled Cython runtime The wheel ships fb303 and hive_metastore as top-level packages (setup.py package_dir), so the LICENSE entries pointing at vendor/ were wrong in binary distributions, and the compiled decoder_fast module embeds Cython runtime code that was not documented. Reword both vendored entries to describe each layout and add a Cython entry, raised in the 0.12.0 release vote thread. Generated-by: Claude Code (Fable 5) Co-Authored-By: Claude Fable 5 --- LICENSE | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/LICENSE b/LICENSE index ffdd12aad2..bad56be56b 100644 --- a/LICENSE +++ b/LICENSE @@ -216,7 +216,9 @@ License: https://www.apache.org/licenses/LICENSE-2.0 This product includes code from Apache Thrift. -* Uses the fb303.thrift file that's part of Hive's thrift service in vendor/fb303/ +* Uses the fb303.thrift file that's part of Hive's thrift service, located in + vendor/fb303/ in the source distribution and shipped as the top-level fb303 + package in binary distributions. Copyright: 2006-2022 The Apache Software Foundation. Home page: https://thrift.apache.org/ @@ -226,10 +228,23 @@ License: https://www.apache.org/licenses/LICENSE-2.0 This product includes code from Apache Hive. -* Uses hive_metastore.thrift to generate the Hive Metastore client in vendor/hive_metastore/ +* Uses hive_metastore.thrift to generate the Hive Metastore client, located in + vendor/hive_metastore/ in the source distribution and shipped as the + top-level hive_metastore package in binary distributions. Copyright: 2008-2022 The Apache Software Foundation. Home page: https://hive.apache.org/ License: https://www.apache.org/licenses/LICENSE-2.0 -------------------------------------------------------------------------------- + +This product includes code from Cython in binary distributions. + +* The compiled extension module (pyiceberg.avro.decoder_fast) embeds the + Cython runtime code that Cython generates into every compiled module. + +Copyright: The Cython Project Developers. +Home page: https://cython.org/ +License: https://www.apache.org/licenses/LICENSE-2.0 + +-------------------------------------------------------------------------------- From 56f88eb56ec9c76a471bd9525d01470f62fb0e8e Mon Sep 17 00:00:00 2001 From: Shayn Hornik Date: Mon, 7 Sep 2026 08:50:00 -0400 Subject: [PATCH 2/2] Build: Cite Cython's COPYING.txt instead of an invented copyright line Cython's LICENSE.txt carries no copyright holder line, so drop the one this entry made up and instead record why the bundled runtime needs no NOTICE change, as requested in review. Co-Authored-By: Claude Fable 5.1 Claude-Session: https://claude.ai/code/session_01SQc71d6jDK1U3i4mP9os5i --- LICENSE | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/LICENSE b/LICENSE index bad56be56b..769ea33612 100644 --- a/LICENSE +++ b/LICENSE @@ -242,9 +242,12 @@ This product includes code from Cython in binary distributions. * The compiled extension module (pyiceberg.avro.decoder_fast) embeds the Cython runtime code that Cython generates into every compiled module. + Cython's COPYING.txt states that this generated output is not a derivative + work of Cython and carries no additional license restrictions; Cython ships + no NOTICE file, so this entry is recorded for completeness only. -Copyright: The Cython Project Developers. Home page: https://cython.org/ License: https://www.apache.org/licenses/LICENSE-2.0 +Notice: https://github.com/cython/cython/blob/master/COPYING.txt --------------------------------------------------------------------------------